Subject: Re: [net-next PATCH v8 5/8] net: dsa: realtek: rtl8365mb: add VLAN support

From: Jakub Kicinski <[email-masked]>
Date: Wed, 27 May 2026 17:36:10 -0700

On Mon, 25 May 2026 16:48:01 -0300 Luiz Angelo Daros de Luca wrote:
> + * rtl8365mb_vlan_port_get_pvid - Retrieve the port PVID
> + * @priv: realtek switch private structure
> + * @port: port index
> + * @pvid: pointer to store the retrieved VLAN ID
> + *
> + * Returns the port PVID if defined or 0 if not.
> + *
> + * Context: Can sleep. Takes and releases &priv->map_lock.
> + * Returns 0 on success or a negative error code on failure.
> + */
> +int rtl8365mb_vlan_port_get_pvid(struct realtek_priv *priv, int port, u16 *pvid)

Warning: drivers/net/dsa/realtek/rtl8365mb_vlan.c:686 No description found for return value of 'rtl8365mb_vlan_port_get_pvid'

Personal preference but IMHO use of kdoc on international driver
functions is plenty pain for little gain. Maybe y'all use more advanced
code editors or such that makes this useful? For me it's just lots of
unnecessary metadata and kdoc warning risk, where a normal comment would
do just fine to convey the information 🤷️ 

Rant over, your driver your call.

> +/**
> + * rtl8365mb_vlan_mc_find() - find VLANMC index by VID or the first free index
> + *
> + * @priv: realtek_priv pointer
> + * @vid: VLAN ID
> + * @index: found index
> + * @first_free: found free index
> + *
> + * If a VLAN MC entry using @vid was found, @index will return the matched index
> + * and @first_free is undefined. If not found, @index will return 0 and
> + * @first_free will return the first found free index in VLAN MC or 0 if the
> + * table is full.
> + *
> + * Although 0 is a valid VLAN MC index, it is reserved for ports without PVID,
> + * including standalone, non-member ports. It uses VID == 0.
> + *
> + * Both @index and @first_free will be in the * 1..@RTL8365MB_VLAN_MCMAX range.
> + *
> + * Return: Returns 0 on success, a negative error on failure.
> + *
> + */

nit: extra line at the end here
-- 
pw-bot: cr