Subject: Re: [PATCH net-next v2 2/2] pcnet32: switch to napi_alloc_skb() and napi_gro_receive()

From: Jakub Kicinski <[email-masked]>
Date: Thu, 28 May 2026 12:12:10 -0700

On Thu, 28 May 2026 19:05:10 +0200 Oscar Maes wrote:
> On Thu, May 28, 2026 at 08:07:48AM -0700, Jakub Kicinski wrote:
> > On Thu, 28 May 2026 16:28:51 +0200 Oscar Maes wrote:  
> > > On Mon, May 25, 2026 at 08:45:28AM -0700, Jakub Kicinski wrote:  
> > > Intel x86  
> > 
> > LOL. Please. Which _hardware_ platform.
> > Or to ask more directly - is it QEMU.  
> 
> It was indeed tested on QEMU.
> Either way, the performance measurements were just a sanity check.
> Changing the code to use the modern API is just better.

Please don't waste our time with optimizations to unused code.