From: Thomas Gleixner <tglx@kernel•org>
To: LKML <linux-kernel@vger•kernel.org>
Cc: David Woodhouse <dwmw2@infradead•org>,
Miroslav Lichvar <mlichvar@redhat•com>,
John Stultz <jstultz@google•com>, Stephen Boyd <sboyd@kernel•org>,
Anna-Maria Behnsen <anna-maria@linutronix•de>,
Frederic Weisbecker <frederic@kernel•org>,
thomas.weissschuh@linutronix•de,
Arthur Kiyanovski <akiyano@amazon•com>,
Rodolfo Giometti <giometti@enneenne•com>,
Vincent Donnefort <vdonnefort@google•com>,
Marc Zyngier <maz@kernel•org>,
Oliver Upton <oliver.upton@linux•dev>,
kvmarm@lists•linux.dev, Oliver Upton <oupton@kernel•org>,
Richard Cochran <richardcochran@gmail•com>,
netdev@vger•kernel.org, Takashi Iwai <tiwai@suse•com>,
Miri Korenblit <miriam.rachel.korenblit@intel•com>,
Johannes Berg <johannes.berg@intel•com>,
Jacob Keller <jacob.e.keller@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Peter Hilber <peter.hilber@oss•qualcomm.com>,
"Michael S. Tsirkin" <mst@redhat•com>,
virtualization@lists•linux.dev, linux-wireless@vger•kernel.org,
linux-sound@vger•kernel.org, David Woodhouse <dwmw@amazon•co.uk>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>
Subject: [patch V2 09/25] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id()
Date: Fri, 29 May 2026 22:00:24 +0200 [thread overview]
Message-ID: <20260529195557.380601005@kernel.org> (raw)
In-Reply-To: 20260529193435.921555544@kernel.org
From: Thomas Gleixner <tglx@kernel•org>
Now that all users are converted it's possible to enable snapshotting of
CLOCK_AUX time. The underlying clocksource is the same as for all other
CLOCK variants.
Signed-off-by: Thomas Gleixner <tglx@kernel•org>
Tested-by: Arthur Kiyanovski <akiyano@amazon•com>
Reviewed-by: David Woodhouse <dwmw@amazon•co.uk>
Reviewed-by: Thomas Weißschuh <thomas.weissschuh@linutronix•de>
Reviewed-by: Jacob Keller <jacob.e.keller@intel•com>
---
kernel/time/timekeeping.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -67,6 +67,7 @@ static inline bool tk_is_aux(const struc
{
return tk->id >= TIMEKEEPER_AUX_FIRST && tk->id <= TIMEKEEPER_AUX_LAST;
}
+static inline struct tk_data *aux_get_tk_data(clockid_t id);
#else
static inline bool tk_get_aux_ts64(unsigned int tkid, struct timespec64 *ts)
{
@@ -77,6 +78,10 @@ static inline bool tk_is_aux(const struc
{
return false;
}
+static inline struct tk_data *aux_get_tk_data(clockid_t id)
+{
+ return NULL;
+}
#endif
static inline void tk_update_aux_offs(struct timekeeper *tk, ktime_t offs)
@@ -1218,6 +1223,12 @@ void ktime_get_snapshot_id(clockid_t clo
tkd = &tk_core;
offs = &tk_core.timekeeper.offs_boot;
break;
+ case CLOCK_AUX ... CLOCK_AUX_LAST:
+ tkd = aux_get_tk_data(clock_id);
+ if (!tkd)
+ return;
+ offs = &tkd->timekeeper.offs_aux;
+ break;
default:
WARN_ON_ONCE(1);
return;
@@ -1228,6 +1239,10 @@ void ktime_get_snapshot_id(clockid_t clo
do {
seq = read_seqcount_begin(&tkd->seq);
+ /* Aux clocks can be invalid */
+ if (!tk->clock_valid)
+ return;
+
now = tk_clock_read(&tk->tkr_mono);
systime_snapshot->cs_id = tk->tkr_mono.clock->id;
systime_snapshot->cs_was_changed_seq = tk->cs_was_changed_seq;
next prev parent reply other threads:[~2026-05-29 20:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 19:59 [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Thomas Gleixner
2026-05-29 19:59 ` [patch V2 01/25] timekeeping: Provide ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 19:59 ` [patch V2 02/25] timekeeping: Use system_time_snapshot::systime/monoraw instead of ::real/raw Thomas Gleixner
2026-05-29 19:59 ` [patch V2 03/25] pps: generators: Use ktime_get_real_ts64() instead of ktime_get_snapshot() Thomas Gleixner
2026-05-30 11:04 ` Rodolfo Giometti
2026-05-29 20:00 ` [patch V2 04/25] pps: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-30 11:08 ` Rodolfo Giometti
2026-06-02 9:31 ` Thomas Gleixner
2026-06-02 10:56 ` David Woodhouse
2026-05-29 20:00 ` [patch V2 05/25] KVM: arm64: Use ktime_get_snapshot_id() to retrieve CLOCK_BOOTTIME Thomas Gleixner
2026-05-29 20:00 ` [patch V2 06/25] KVM: arm64: Use ktime_get_snapshot_id() to snapshot CLOCK_REALTIME Thomas Gleixner
2026-05-29 20:00 ` [patch V2 07/25] ptp: ptp_vmclock: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 20:00 ` [patch V2 08/25] timekeeping: Remove system_time_snapshot::real/boot/raw Thomas Gleixner
2026-05-29 20:00 ` Thomas Gleixner [this message]
2026-05-29 20:00 ` [patch V2 10/25] timekeeping: Add system_counterval_t to struct system_device_crosststamp Thomas Gleixner
2026-05-29 20:00 ` [patch V2 11/25] timekeeping: Add CLOCK ID to system_device_crosststamp Thomas Gleixner
2026-05-29 20:00 ` [patch V2 12/25] wifi: iwlwifi: Adopt PTP cross timestamps to core changes Thomas Gleixner
2026-05-29 20:00 ` [patch V2 13/25] ice/ptp: Use provided clock ID for history snapshot Thomas Gleixner
2026-05-29 20:00 ` [patch V2 14/25] igc: " Thomas Gleixner
2026-05-29 20:00 ` [patch V2 15/25] net/mlx5: " Thomas Gleixner
2026-05-29 20:00 ` [patch V2 16/25] virtio_rtc: " Thomas Gleixner
2026-06-02 14:44 ` Peter Hilber
2026-05-29 20:00 ` [patch V2 17/25] timekeeping: Remove ktime_get_snapshot() Thomas Gleixner
2026-05-29 20:01 ` [patch V2 18/25] timekeeping: Prepare for cross timestamps on arbitrary clock IDs Thomas Gleixner
2026-05-29 20:01 ` [patch V2 19/25] ptp: Use system_device_crosststamp::sys_systime Thomas Gleixner
2026-05-29 20:01 ` [patch V2 20/25] wifi: iwlwifi: " Thomas Gleixner
2026-05-29 20:01 ` [patch V2 21/25] ALSA: hda/common: " Thomas Gleixner
2026-06-02 17:46 ` Takashi Iwai
2026-05-29 20:01 ` [patch V2 22/25] timekeeping: Remove system_device_crosststamp::sys_realtime Thomas Gleixner
2026-05-29 20:01 ` [patch V2 23/25] timekeeping: Add support for AUX clock cross timestamping Thomas Gleixner
2026-05-29 20:01 ` [patch V2 24/25] ptp: Switch to ktime_get_snapshot_id() for pre/post timestamps Thomas Gleixner
2026-05-29 20:01 ` [patch V2 25/25] timekeeping: Add clocksource read_snapshot() method and hw_cycles to snapshot Thomas Gleixner
2026-05-29 20:33 ` [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Jacob Keller
2026-06-01 10:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260529195557.380601005@kernel.org \
--to=tglx@kernel$(echo .)org \
--cc=akiyano@amazon$(echo .)com \
--cc=anna-maria@linutronix$(echo .)de \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=dwmw2@infradead$(echo .)org \
--cc=dwmw@amazon$(echo .)co.uk \
--cc=frederic@kernel$(echo .)org \
--cc=giometti@enneenne$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=johannes.berg@intel$(echo .)com \
--cc=jstultz@google$(echo .)com \
--cc=kvmarm@lists$(echo .)linux.dev \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-sound@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=maz@kernel$(echo .)org \
--cc=miriam.rachel.korenblit@intel$(echo .)com \
--cc=mlichvar@redhat$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oliver.upton@linux$(echo .)dev \
--cc=oupton@kernel$(echo .)org \
--cc=peter.hilber@oss$(echo .)qualcomm.com \
--cc=richardcochran@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sboyd@kernel$(echo .)org \
--cc=thomas.weissschuh@linutronix$(echo .)de \
--cc=tiwai@suse$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=vdonnefort@google$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox