From: Jakub Kicinski <kuba@kernel•org>
To: Xin Long <lucien.xin@gmail•com>
Cc: network dev <netdev@vger•kernel.org>,
quic@lists•linux.dev, davem@davemloft•net,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Simon Horman <horms@kernel•org>,
Stefan Metzmacher <metze@samba•org>,
Moritz Buhl <mbuhl@openbsd•org>,
Tyler Fanelli <tfanelli@redhat•com>,
Pengtao He <hepengtao@xiaomi•com>,
Thomas Dreibholz <dreibh@simula•no>,
linux-cifs@vger•kernel.org, Steve French <smfrench@gmail•com>,
Namjae Jeon <linkinjeon@kernel•org>, Tom Talpey <tom@talpey•com>,
kernel-tls-handshake@lists•linux.dev,
Chuck Lever <chuck.lever@oracle•com>,
Jeff Layton <jlayton@kernel•org>,
Steve Dickson <steved@redhat•com>, Hannes Reinecke <hare@suse•de>,
Alexander Aring <aahringo@redhat•com>,
David Howells <dhowells@redhat•com>,
Matthieu Baerts <matttbe@kernel•org>,
John Ericson <mail@johnericson•me>,
Cong Wang <xiyou.wangcong@gmail•com>,
"D . Wythe" <alibuda@linux•alibaba.com>,
Jason Baron <jbaron@akamai•com>,
illiliti <illiliti@protonmail•com>,
Sabrina Dubroca <sd@queasysnail•net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail•com>,
Daniel Stenberg <daniel@haxx•se>,
Andy Gospodarek <andrew.gospodarek@broadcom•com>,
mef@scarletmail•rutgers.edu, paul@jakma•org
Subject: Re: [PATCH net-next v12 00/15] net: introduce QUIC infrastructure and core subcomponents
Date: Tue, 2 Jun 2026 11:18:23 -0700 [thread overview]
Message-ID: <20260602111823.0b1129d6@kernel.org> (raw)
In-Reply-To: <CADvbK_fBbLCwY61HXsNeGCA8MhiBKcbvE0BvSZppohJgtXO+2g@mail.gmail.com>
On Tue, 2 Jun 2026 09:12:30 -0400 Xin Long wrote:
> Note: I've run Sashiko on this patchset many times locally over the past
> month and addressed all the real issues it found. I don't see any new real
> issues being reported on:
Coccinelle had a report tho:
The NIPA CI coccicheck run flagged a new Coccinelle warning introduced by
this patch:
net/quic/crypto.c:1164:13-20: WARNING opportunity for kmemdup
At line 1164 of the newly introduced net/quic/crypto.c, there is a
kmalloc() call immediately followed by a memcpy() into the allocated
buffer. Coccinelle's memdup checker suggests replacing this two-step
pattern with a single kmemdup() call, which is the preferred kernel idiom.
The fix is straightforward - replacing:
p = kmalloc(len, gfp);
if (!p)
return -ENOMEM;
memcpy(p, src, len);
with:
p = kmemdup(src, len, gfp);
if (!p)
return -ENOMEM;
Please update the patch to use kmemdup() at that location.
next prev parent reply other threads:[~2026-06-02 18:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 13:08 [PATCH net-next v12 00/15] net: introduce QUIC infrastructure and core subcomponents Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 01/15] net: define IPPROTO_QUIC and SOL_QUIC constants Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 02/15] net: build socket infrastructure for QUIC protocol Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 03/15] quic: provide common utilities and data structures Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 04/15] quic: provide family ops for address and protocol Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 05/15] quic: provide quic.h header files for kernel and userspace Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 06/15] quic: add stream management Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 07/15] quic: add connection id management Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 08/15] quic: add path management Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 09/15] quic: add congestion control Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 10/15] quic: add packet number space Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 11/15] quic: add crypto key derivation and installation Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 12/15] quic: add crypto packet encryption and decryption Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 13/15] quic: add timer management Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 14/15] quic: add packet builder base Xin Long
2026-05-31 13:08 ` [PATCH net-next v12 15/15] quic: add packet parser base Xin Long
2026-06-02 13:12 ` [PATCH net-next v12 00/15] net: introduce QUIC infrastructure and core subcomponents Xin Long
2026-06-02 18:18 ` Jakub Kicinski [this message]
2026-06-03 14:14 ` Xin Long
2026-06-03 17:39 ` Jakub Kicinski
2026-06-03 18:15 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602111823.0b1129d6@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=aahringo@redhat$(echo .)com \
--cc=alibuda@linux$(echo .)alibaba.com \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=chuck.lever@oracle$(echo .)com \
--cc=daniel@haxx$(echo .)se \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=dreibh@simula$(echo .)no \
--cc=edumazet@google$(echo .)com \
--cc=hare@suse$(echo .)de \
--cc=hepengtao@xiaomi$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=illiliti@protonmail$(echo .)com \
--cc=jbaron@akamai$(echo .)com \
--cc=jlayton@kernel$(echo .)org \
--cc=kernel-tls-handshake@lists$(echo .)linux.dev \
--cc=linkinjeon@kernel$(echo .)org \
--cc=linux-cifs@vger$(echo .)kernel.org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=mail@johnericson$(echo .)me \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=matttbe@kernel$(echo .)org \
--cc=mbuhl@openbsd$(echo .)org \
--cc=mef@scarletmail$(echo .)rutgers.edu \
--cc=metze@samba$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=paul@jakma$(echo .)org \
--cc=quic@lists$(echo .)linux.dev \
--cc=sd@queasysnail$(echo .)net \
--cc=smfrench@gmail$(echo .)com \
--cc=steved@redhat$(echo .)com \
--cc=tfanelli@redhat$(echo .)com \
--cc=tom@talpey$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox