From: Eric Biggers <ebiggers@kernel•org>
To: Marc Dionne <marc.c.dionne@gmail•com>
Cc: netdev@vger•kernel.org, linux-afs@lists•infradead.org,
David Howells <dhowells@redhat•com>,
linux-crypto@vger•kernel.org, linux-kernel@vger•kernel.org,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Simon Horman <horms@kernel•org>
Subject: Re: [PATCH net-next v2 0/5] Consolidate FCrypt and PCBC code into net/rxrpc/
Date: Tue, 2 Jun 2026 22:05:57 -0700 [thread overview]
Message-ID: <20260603050557.GB18149@sol> (raw)
In-Reply-To: <CAB9dFduBir-41_Ef4noEJPHsFU-++JHDxMU-6S7B8pBYynvadA@mail.gmail.com>
On Fri, May 22, 2026 at 10:06:49AM -0300, Marc Dionne wrote:
> On Fri, May 22, 2026 at 2:07 AM Eric Biggers <ebiggers@kernel•org> wrote:
> >
> > The FCrypt "block cipher" and the PCBC mode of operation are obsolete
> > and insecure. Since their only user is net/rxrpc/, they belong there,
> > not in the crypto API.
> >
> > Therefore, this series removes these algorithms from the crypto API and
> > replaces them with local implementations in net/rxrpc/.
> >
> > The local implementations are simpler too, as they avoid the crypto API
> > boilerplate.
> >
> > I don't know how to test all the code in net/rxrpc/, but everything
> > should still work. I added a KUnit test for the crypto functions.
> >
> > Changed in v2:
> > - Added missing export of fcrypt_preparekey().
> > - Write "RxRPC crypto KUnit test" instead of "RxRPC KUnit test".
> > - Rebased onto latest net-next where decryption now happens in the
> > linear buffer rxrpc_call::rx_dec_buffer, simplifying the code.
>
> Looks good in testing with our kafs test suite, forcing the use of
> rxkad with encryption.
>
> Feel free to add for the series:
> Tested-by: Marc Dionne <marc.dionne@auristor•com>
Thanks!
If there's no more feedback, could this be applied to net-next?
- Eric
prev parent reply other threads:[~2026-06-03 5:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 5:07 [PATCH net-next v2 0/5] Consolidate FCrypt and PCBC code into net/rxrpc/ Eric Biggers
2026-05-22 5:07 ` [PATCH net-next v2 1/5] net/rxrpc: Add local FCrypt-PCBC implementation Eric Biggers
2026-05-22 5:07 ` [PATCH net-next v2 2/5] net/rxrpc: Use " Eric Biggers
2026-05-22 5:07 ` [PATCH net-next v2 3/5] net/rxrpc: Reimplement DES-PCBC using DES library Eric Biggers
2026-05-22 5:07 ` [PATCH net-next v2 4/5] crypto: fcrypt - Remove support for FCrypt block cipher Eric Biggers
2026-05-22 5:07 ` [PATCH net-next v2 5/5] crypto: pcbc - Remove support for PCBC mode Eric Biggers
2026-05-22 13:06 ` [PATCH net-next v2 0/5] Consolidate FCrypt and PCBC code into net/rxrpc/ Marc Dionne
2026-06-03 5:05 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603050557.GB18149@sol \
--to=ebiggers@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=marc.c.dionne@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox