Subject: Re: [net-next PATCH v11 6/9] net: dsa: realtek: rtl8365mb: add VLAN support

From: Jakub Kicinski <[email-masked]>
Date: Wed, 3 Jun 2026 17:56:17 -0700

On Sun, 31 May 2026 23:53:21 -0300 Luiz Angelo Daros de Luca wrote:
> +#define RTL_VLAN_ERR(msg)						\
> +	do {								\
> +		const char *__msg = (msg);				\
> +									\
> +		if (extack)						\
> +			NL_SET_ERR_MSG_FMT_MOD(extack, "%s", __msg);	\
> +		dev_err(priv->dev, "%s", __msg);			\
> +	} while (0)

Please don't duplicate errors. The errors are either due to something
being wrong / unsupported in the request in which case they should go
via extack. Or they are unexpected system errors (IO errors, timeouts 
and such) in which case just return errno and print to the logs 
so that the admin has a permanent record.

There's a tracepoint in NL_SET_ERR_MSG() if you want to sniff
user errors.
-- 
pw-bot: cr