From: Simon Horman <horms@kernel•org>
To: Robertus Diawan Chris <robertusdchris@gmail•com>
Cc: alex.aring@gmail•com, stefan@datenfreihafen•org,
miquel.raynal@bootlin•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
linux-wpan@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
linux-kernel-mentees@lists•linuxfoundation.org,
skhan@linuxfoundation•org, me@brighamcampbell•com
Subject: Re: [PATCH] mac802154: Prevent overwrite return code in mac802154_perform_association()
Date: Thu, 4 Jun 2026 18:28:40 +0100 [thread overview]
Message-ID: <20260604172840.GE3920875@horms.kernel.org> (raw)
In-Reply-To: <20260602054133.470293-1-robertusdchris@gmail.com>
On Tue, Jun 02, 2026 at 12:41:33PM +0700, Robertus Diawan Chris wrote:
> When assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL, the
> return value assigned to either "-ERANGE" or "-EPERM" but this return
> value will be overwritten to 0 after exiting the conditional scope.
> So, jump to clear_assoc label to preserve the return value when
> assoc_status not equal to IEEE802154_ASSOCIATION_SUCCESSFUL.
>
> This is reported by Coverity Scan as "Unused value".
>
> Fixes: fefd19807fe9 ("mac802154: Handle associating")
> Signed-off-by: Robertus Diawan Chris <robertusdchris@gmail•com>
FTR: An AI generated review of this patch is available on sashiko.dev.
I believe that review can be treated in the context of possible follow-up
and should not effect the progress of this patch.
prev parent reply other threads:[~2026-06-04 17:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 5:41 [PATCH] mac802154: Prevent overwrite return code in mac802154_perform_association() Robertus Diawan Chris
2026-06-02 10:35 ` Miquel Raynal
2026-06-04 17:28 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604172840.GE3920875@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=alex.aring@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel-mentees@lists$(echo .)linuxfoundation.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wpan@vger$(echo .)kernel.org \
--cc=me@brighamcampbell$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robertusdchris@gmail$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=stefan@datenfreihafen$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox