From: Rob Herring <robh@kernel•org>
To: Alex Elder <elder@riscstar•com>
Cc: andrew+netdev@lunn•ch, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com,
maxime.chevallier@bootlin•com, rmk+kernel@armlinux•org.uk,
andersson@kernel•org, konradybcio@kernel•org, krzk+dt@kernel•org,
conor+dt@kernel•org, linusw@kernel•org, brgl@kernel•org,
arnd@arndb•de, gregkh@linuxfoundation•org,
Daniel Thompson <daniel@riscstar•com>,
mohd.anwar@oss•qualcomm.com, a0987203069@gmail•com,
alexandre.torgue@foss•st.com, ast@kernel•org,
boon.khai.ng@altera•com, chenchuangyu@xiaomi•com,
chenhuacai@kernel•org, daniel@iogearbox•net, hawk@kernel•org,
hkallweit1@gmail•com, inochiama@gmail•com,
john.fastabend@gmail•com, julianbraha@gmail•com,
livelycarpet87@gmail•com, mcoquelin.stm32@gmail•com, me@ziyao•cc,
prabhakar.mahadev-lad.rj@bp•renesas.com,
richardcochran@gmail•com, rohan.g.thomas@altera•com,
sdf@fomichev•me, siyanteng@cqsoftware•com.cn,
weishangjuan@eswincomputing•com, wens@kernel•org,
netdev@vger•kernel.org, bpf@vger•kernel.org,
linux-arm-msm@vger•kernel.org, devicetree@vger•kernel.org,
linux-gpio@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v2 13/14] net: stmmac: tc956x: add TC956x/QPS615 support
Date: Fri, 5 Jun 2026 09:47:58 -0500 [thread overview]
Message-ID: <20260605144758.GB3659201-robh@kernel.org> (raw)
In-Reply-To: <20260605010022.968612-14-elder@riscstar.com>
On Thu, Jun 04, 2026 at 08:00:20PM -0500, Alex Elder wrote:
> From: Daniel Thompson <daniel@riscstar•com>
>
> Toshiba TC956x is an Ethernet AVB/TSN bridge and is essentially a
> small and highly-specialized SoC. TC956x includes an "eMAC" subsystem
> that can be accessed, along with several other peripherals, via two
> PCIe endpoint functions. There is a main driver for the endpoint that
> decomposes things and creates auxiliary bus devices to model the SoC.
>
> The eMAC consists of a Designware XGMAC, XPCS and PMA. Each eMAC is
> supported by an MSIGEN that bridges TC956x level interrupts to PCIe
> MSIs.
>
> Add a driver for the eMAC/MSIGEN combination.
>
> Co-developed-by: Alex Elder <elder@riscstar•com>
> Signed-off-by: Alex Elder <elder@riscstar•com>
> Signed-off-by: Daniel Thompson <daniel@riscstar•com>
The order is wrong here unless you worked on it and then Daniel took
over. Tags should be chronological order.
> ---
> MAINTAINERS | 2 +
> drivers/net/ethernet/stmicro/stmmac/Kconfig | 14 +
> drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +
> .../ethernet/stmicro/stmmac/dwmac-tc956x.c | 818 ++++++++++++++++++
> 4 files changed, 836 insertions(+)
> create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-tc956x.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0439607d1155f..418537cbefbbb 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27059,6 +27059,8 @@ S: Maintained
> F: Documentation/devicetree/bindings/net/toshiba,tc956x-dwmac.yaml
> F: drivers/gpio/gpio-tc956x.c
> F: drivers/misc/tc956x_pci.c
> +F: drivers/net/ethernet/stmicro/stmmac/dwmac-tc956x.c
> +F: include/soc/toshiba/tc956x-dwmac.h
>
> TOSHIBA WMI HOTKEYS DRIVER
> M: Azael Avalos <coproscefalo@gmail•com>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> index e3dd5adda5aca..8d247e033e356 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
> +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
> @@ -404,6 +404,20 @@ config DWMAC_MOTORCOMM
> This enables glue driver for Motorcomm DWMAC-based PCI Ethernet
> controllers. Currently only YT6801 is supported.
>
> +config DWMAC_TC956X
> + tristate "Toshiba TC956X DWMAC support"
> + depends on PCI
> + depends on COMMON_CLK
> + depends on TOSHIBA_TC956X_PCI
> + default TOSHIBA_TC956X_PCI
> + select GENERIC_IRQ_CHIP
> + help
> + This selects the Toshiba TC956X (and Qualcomm QPS615) support in the
> + stmmac driver.
> +
> + This provides support for the ethernet controllers found on these
> + devices.
> +
> config STMMAC_PCI
> tristate "STMMAC PCI bus support"
> depends on PCI
> diff --git a/drivers/net/ethernet/stmicro/stmmac/Makefile b/drivers/net/ethernet/stmicro/stmmac/Makefile
> index a1cea2f57252e..e8e7f95dbe3e8 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/Makefile
> +++ b/drivers/net/ethernet/stmicro/stmmac/Makefile
> @@ -51,4 +51,6 @@ obj-$(CONFIG_STMMAC_PCI) += stmmac-pci.o
> obj-$(CONFIG_DWMAC_INTEL) += dwmac-intel.o
> obj-$(CONFIG_DWMAC_LOONGSON) += dwmac-loongson.o
> obj-$(CONFIG_DWMAC_MOTORCOMM) += dwmac-motorcomm.o
> +obj-$(CONFIG_TC956X_PCI) += tc956x-pci.o
> +obj-$(CONFIG_DWMAC_TC956X) += dwmac-tc956x.o
> stmmac-pci-objs:= stmmac_pci.o
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-tc956x.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-tc956x.c
> new file mode 100644
> index 0000000000000..c77585e4a50e6
> --- /dev/null
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-tc956x.c
> @@ -0,0 +1,818 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +/*
> + * Copyright (C) 2026 by RISCstar Solutions Corporation. All rights reserved.
> + *
> + * Derived from code having the following copyrights:
> + * Copyright (C) 2011-2012 Vayavya Labs Pvt Ltd
> + * Copyright (C) 2025 Toshiba Electronic Devices & Storage Corporation
> + */
> +
> +#include <linux/auxiliary_bus.h>
Based on the block diagram, these are PCI devices. Auxiliary bus is the
wrong thing to use here.
Rob
next prev parent reply other threads:[~2026-06-05 14:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 1:00 [PATCH net-next v2 00/14] net: enable TC956x support Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 01/14] dt-bindings: net: qca,qca808x: Add regulator properties Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 02/14] net: phy: qcom: qca808x: Add regulator management Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 03/14] net: pcs: pcs-xpcs-regmap: support XPCS memory-mapped MDIO bus via regmap Alex Elder
2026-06-05 15:35 ` Maxime Chevallier
2026-06-05 1:00 ` [PATCH net-next v2 04/14] net: pcs: xpcs: re-order xpcs_pre_config() to update after the reset Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 05/14] net: pcs: pcs-xpcs: select operating mode for 10G-baseR capable PCS Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 06/14] net: stmmac: dma: create a separate dma_device pointer Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 07/14] net: stmmac: dwxgmac2: Add multi MSI interrupt mode Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 08/14] net: stmmac: dwxgmac2: Add XGMAC 3.01a support Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 09/14] net: stmmac: dwxgmac2: export symbols for XGMAC 3.01a DMA Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 10/14] dt-bindings: net: toshiba,tc9654-dwmac: add TC9564 Ethernet bridge Alex Elder
2026-06-05 2:40 ` Rob Herring (Arm)
2026-06-05 12:24 ` Alex Elder
2026-06-05 14:40 ` Rob Herring
2026-06-05 1:00 ` [PATCH net-next v2 11/14] misc: tc956x_pci: add TC956x/QPS615 support Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 12/14] gpio: tc956x: " Alex Elder
2026-06-05 1:00 ` [PATCH net-next v2 13/14] net: stmmac: " Alex Elder
2026-06-05 14:47 ` Rob Herring [this message]
2026-06-05 16:05 ` Maxime Chevallier
2026-06-05 1:00 ` [PATCH net-next v2 14/14] arm64: dts: qcom: qcs6490-rb3gen2: enable TC9564 with a single QCA8081 phy Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260605144758.GB3659201-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=a0987203069@gmail$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andersson@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=ast@kernel$(echo .)org \
--cc=boon.khai.ng@altera$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brgl@kernel$(echo .)org \
--cc=chenchuangyu@xiaomi$(echo .)com \
--cc=chenhuacai@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=daniel@iogearbox$(echo .)net \
--cc=daniel@riscstar$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=elder@riscstar$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hawk@kernel$(echo .)org \
--cc=hkallweit1@gmail$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=julianbraha@gmail$(echo .)com \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linusw@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=livelycarpet87@gmail$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=me@ziyao$(echo .)cc \
--cc=mohd.anwar@oss$(echo .)qualcomm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=prabhakar.mahadev-lad.rj@bp$(echo .)renesas.com \
--cc=richardcochran@gmail$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=rohan.g.thomas@altera$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=siyanteng@cqsoftware$(echo .)com.cn \
--cc=weishangjuan@eswincomputing$(echo .)com \
--cc=wens@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox