Subject: Re: [PATCH] flow_dissector: fix uninit-value in __skb_flow_dissect() for ETH_ADDRS

From: Jakub Kicinski <[email-masked]>
Date: Mon, 8 Jun 2026 13:43:30 -0700

On Mon, 8 Jun 2026 09:30:12 +0800 Zhou, Yun wrote:
> Hi Jakub,
> 
> What is your opinion on this fix method?

This looks good, thanks for pointing out.

Please adjust the commit message explaining the problem, the setup that
triggers it, and problems with the control path approach. 

The comment above the skb_mac_header_was_set() should also say _why_
this is hard to check in the control path, right now they comment
just restates what the code does.

Thanks!