From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
andrew+netdev@lunn•ch, horms@kernel•org, shuah@kernel•org,
willemb@google•com, linux-kselftest@vger•kernel.org
Subject: Re: [PATCH net-next] selftests: drv-net: gro: signal over-coalescing more reliably
Date: Mon, 8 Jun 2026 19:53:20 -0700 [thread overview]
Message-ID: <20260608195320.007b34ad@kernel.org> (raw)
In-Reply-To: <20260607002401.212976-1-kuba@kernel.org>
On Sat, 6 Jun 2026 17:24:01 -0700 Jakub Kicinski wrote:
> + /* Signal over-coalescing explicitly, it's a hard failure, unlike
> + * under-coalescing which could be timing- or loss-related.
> + */
> + if (num_pkt < correct_num_pkts && bytes_received == bytes_expected)
> + error(EXIT_OVER_COALESCE, 0,
> + "over-coalesced: got %d pkts vs expected %d (%d B)",
> + num_pkt, correct_num_pkts, bytes_received);
Sashiko complains that this condition may mis-fire if we lose a zero-len
RST or ACK. This is true, tho, if the device drops pure acks ignoring
failures where ack disappeared puts us back at risk of false negatives.
Happy to respin but feels like we only have bad choices here..
next prev parent reply other threads:[~2026-06-09 2:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-07 0:24 [PATCH net-next] selftests: drv-net: gro: signal over-coalescing more reliably Jakub Kicinski
2026-06-07 13:49 ` Willem de Bruijn
2026-06-09 2:53 ` Jakub Kicinski [this message]
2026-06-09 10:23 ` Paolo Abeni
2026-06-09 10:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608195320.007b34ad@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox