From: kernel test robot <lkp@intel•com>
To: Eric Dumazet <edumazet@google•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>
Cc: oe-kbuild-all@lists•linux.dev, Simon Horman <horms@kernel•org>,
Kuniyuki Iwashima <kuniyu@google•com>,
netdev@vger•kernel.org, eric.dumazet@gmail•com,
Eric Dumazet <edumazet@google•com>,
syzbot+381d82bbf0253710b35d@syzkaller•appspotmail.com,
syzbot+3479efbc2821cb2a79f2@syzkaller•appspotmail.com
Subject: Re: [PATCH net] net: watchdog: fix refcount tracking races
Date: Mon, 8 Jun 2026 22:59:44 +0200 [thread overview]
Message-ID: <202606082235.DIth7s08-lkp@intel.com> (raw)
In-Reply-To: <20260608123935.524879-1-edumazet@google.com>
Hi Eric,
kernel test robot noticed the following build errors:
[auto build test ERROR on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/net-watchdog-fix-refcount-tracking-races/20260608-205327
base: net/main
patch link: https://lore.kernel.org/r/20260608123935.524879-1-edumazet%40google.com
patch subject: [PATCH net] net: watchdog: fix refcount tracking races
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260608/202606082235.DIth7s08-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260608/202606082235.DIth7s08-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel•com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202606082235.DIth7s08-lkp@intel.com/
All errors (new ones prefixed by >>):
net/sched/sch_generic.c: In function 'netdev_watchdog_up':
>> net/sched/sch_generic.c:594:39: error: incompatible type for argument 1 of 'IS_ERR_OR_NULL'
594 | if (IS_ERR_OR_NULL(dev->watchdog_dev_tracker))
| ~~~^~~~~~~~~~~~~~~~~~~~~~
| |
| netdevice_tracker
In file included from include/linux/cleanup.h:6,
from include/linux/jump_label.h:78,
from include/linux/dynamic_debug.h:6,
from include/linux/printk.h:620,
from include/asm-generic/bug.h:31,
from arch/x86/include/asm/bug.h:193,
from arch/x86/include/asm/alternative.h:9,
from arch/x86/include/asm/barrier.h:5,
from include/asm-generic/bitops/generic-non-atomic.h:7,
from include/linux/bitops.h:28,
from net/sched/sch_generic.c:10:
include/linux/err.h:90:68: note: expected 'const void *' but argument is of type 'netdevice_tracker'
90 | static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
| ~~~~~~~~~~~~^~~
vim +/IS_ERR_OR_NULL +594 net/sched/sch_generic.c
584
585 void netdev_watchdog_up(struct net_device *dev)
586 {
587 if (!dev->netdev_ops->ndo_tx_timeout)
588 return;
589 if (dev->watchdog_timeo <= 0)
590 dev->watchdog_timeo = 5*HZ;
591 spin_lock_bh(&dev->tx_global_lock);
592 if (!mod_timer(&dev->watchdog_timer,
593 round_jiffies(jiffies + dev->watchdog_timeo))) {
> 594 if (IS_ERR_OR_NULL(dev->watchdog_dev_tracker))
595 netdev_hold(dev, &dev->watchdog_dev_tracker,
596 GFP_ATOMIC);
597 }
598 spin_unlock_bh(&dev->tx_global_lock);
599 }
600 EXPORT_SYMBOL_GPL(netdev_watchdog_up);
601
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2026-06-08 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 12:39 [PATCH net] net: watchdog: fix refcount tracking races Eric Dumazet
2026-06-08 16:01 ` Jakub Kicinski
2026-06-08 16:15 ` Eric Dumazet
2026-06-08 20:59 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606082235.DIth7s08-lkp@intel.com \
--to=lkp@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kuniyu@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oe-kbuild-all@lists$(echo .)linux.dev \
--cc=pabeni@redhat$(echo .)com \
--cc=syzbot+3479efbc2821cb2a79f2@syzkaller$(echo .)appspotmail.com \
--cc=syzbot+381d82bbf0253710b35d@syzkaller$(echo .)appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox