From: Christian Lamparter <chunkeey@gmail•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: netdev@vger•kernel.org, Florian Fainelli <f.fainelli@gmail•com>,
Vivien Didelot <vivien.didelot@gmail•com>
Subject: Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation
Date: Tue, 05 Feb 2019 23:12:45 +0100 [thread overview]
Message-ID: <2061891.QOleSDBFsG@debian64> (raw)
In-Reply-To: <20190205212934.GF3243@lunn.ch>
On Tuesday, February 5, 2019 10:29:34 PM CET Andrew Lunn wrote:
> > For now, I added the DT binding update to the patch as well.
> > But if this is indeed the way to go, it'll get a separate patch.
>
> Hi Christian
>
> You need to be careful with the DT binding. You need to keep backwards
> compatible with it. An old DT blob needs to keep working. I don't
> think this is true with this change.
Do you mean because of the
- switch0@0 {
+ switch@10 {
compatible = "qca,qca8337";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0>;
+ reg = <0x10>;
change?
or because I removed the phy-handles?
The reg = <0x10>; will be necessary regardless. Because this
is really a bug in the existing binding example and if it is
copied it will prevent the qca8k driver from loading.
This is due to a resource conflict, because there will be
already a "phy_port1: phy@0" registered at reg = <0>;
So this never worked would have worked.
Regards,
Christian
next prev parent reply other threads:[~2019-02-05 22:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 21:35 [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation Christian Lamparter
2019-02-04 22:11 ` Florian Fainelli
2019-02-04 22:26 ` Andrew Lunn
2019-02-04 23:55 ` Christian Lamparter
2019-02-05 2:45 ` Andrew Lunn
2019-02-05 12:48 ` Christian Lamparter
2019-02-05 13:09 ` Andrew Lunn
2019-02-05 21:08 ` Christian Lamparter
2019-02-05 21:29 ` Andrew Lunn
2019-02-05 22:12 ` Christian Lamparter [this message]
2019-02-05 22:29 ` Florian Fainelli
2019-02-06 21:57 ` Christian Lamparter
2019-02-06 22:29 ` Florian Fainelli
2019-02-06 22:32 ` Florian Fainelli
2019-02-07 0:43 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2061891.QOleSDBFsG@debian64 \
--to=chunkeey@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox