From: Andreas Schultz <aschultz@tpip•net>
To: Harald Welte <laforge@netfilter•org>
Cc: pablo <pablo@netfilter•org>, netdev <netdev@vger•kernel.org>,
Lionel Gauthier <Lionel.Gauthier@eurecom•fr>,
openbsc <openbsc@lists•osmocom.org>
Subject: Re: [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev
Date: Mon, 13 Feb 2017 15:13:37 +0100 (CET) [thread overview]
Message-ID: <2072664575.96405.1486995217363.JavaMail.zimbra@tpip.net> (raw)
In-Reply-To: <20170206135512.sbxvkbe3hzgnwwjt@nataraja>
----- On Feb 6, 2017, at 2:55 PM, Harald Welte laforge@netfilter•org wrote:
> Hi Andreas,
>
> On Mon, Jan 30, 2017 at 05:37:09PM +0100, Andreas Schultz wrote:
>> Both function are always used together with the final goal to
>> get the gtp_dev. This simplifies the code by merging them together.
>
> Ok, some code restructuring / unification, seems useful.
>
> However:
>
>> - netdev_dbg(dev, "GTPv0-U: update tunnel id = %llx (pdp %p)\n",
>> - pctx->u.v0.tid, pctx);
>> + pr_debug("GTPv0-U: update tunnel id = %llx (pdp %p)\n",
>> + pctx->u.v0.tid, pctx);
>
> (and other related changes) appear to be purely cosmetic and should thus
> be unrelated to the function merging described in the change log
> message.
The dev argument has been removed from the surrounding function.
However, for those debug message having the network device information
is use full. I've modified the code in v3 a bit to keep the debug message.
Andreas
>
> --
> - Harald Welte <laforge@netfilter•org> http://netfilter.org/
> ============================================================================
> "Fragmentation is like classful addressing -- an interesting early
> architectural error that shows how much experimentation was going
> on while IP was being designed." -- Paul Vixie
next prev parent reply other threads:[~2017-02-13 14:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 16:37 [PATCH net-next v2 0/6] gtp: misc improvements Andreas Schultz
2017-01-30 16:37 ` [PATCH net-next v2 1/6] gtp: make GTP sockets in gtp_newlink optional Andreas Schultz
2017-02-02 14:10 ` Pablo Neira Ayuso
2017-02-02 14:30 ` Andreas Schultz
2017-02-02 14:32 ` Pablo Neira Ayuso
2017-02-06 13:51 ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 2/6] gtp: merge gtp_get_net and gtp_genl_find_dev Andreas Schultz
2017-02-06 13:55 ` Harald Welte
2017-02-13 14:13 ` Andreas Schultz [this message]
2017-02-13 14:51 ` Pablo Neira Ayuso
2017-01-30 16:37 ` [PATCH net-next v2 3/6] gtp: unify genl_find_pdp and prepare for per socket lookup Andreas Schultz
2017-02-02 14:19 ` Pablo Neira Ayuso
2017-02-02 14:27 ` Andreas Schultz
2017-02-02 14:31 ` Pablo Neira Ayuso
2017-02-06 13:56 ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 4/6] gtp: consolidate pdp context destruction into helper Andreas Schultz
2017-02-06 13:58 ` Harald Welte
2017-02-13 14:14 ` Andreas Schultz
2017-01-30 16:37 ` [PATCH net-next v2 5/6] gtp: add socket to pdp context Andreas Schultz
2017-02-02 13:56 ` Pablo Neira Ayuso
2017-02-02 14:12 ` Andreas Schultz
2017-02-02 14:28 ` Pablo Neira Ayuso
2017-02-02 14:38 ` Andreas Schultz
2017-02-02 14:46 ` Pablo Neira Ayuso
2017-02-02 15:07 ` Andreas Schultz
2017-02-06 14:04 ` Harald Welte
2017-01-30 16:37 ` [PATCH net-next v2 6/6] gtp: consolidate gtp socket rx path Andreas Schultz
2017-01-31 18:05 ` [PATCH net-next v2 0/6] gtp: misc improvements David Miller
2017-02-06 13:46 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2072664575.96405.1486995217363.JavaMail.zimbra@tpip.net \
--to=aschultz@tpip$(echo .)net \
--cc=Lionel.Gauthier@eurecom$(echo .)fr \
--cc=laforge@netfilter$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=openbsc@lists$(echo .)osmocom.org \
--cc=pablo@netfilter$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox