From: Alexander Stein <alexander.stein@ew•tq-group.com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Wei Fang <wei.fang@nxp•com>, Shenwei Wang <shenwei.wang@nxp•com>,
Clark Wang <xiaoning.wang@nxp•com>,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Arnd Bergmann <arnd@arndb•de>,
Andrew Lunn <andrew@lunn•ch>, NXP Linux Team <linux-imx@nxp•com>,
netdev@vger•kernel.org
Subject: Re: [PATCH 1/1] net: fec: Don't fail on missing optional phy-reset-gpios
Date: Tue, 07 Feb 2023 14:24:22 +0100 [thread overview]
Message-ID: <21769138.EfDdHjke4D@steina-w> (raw)
In-Reply-To: <20230206223027.0d65ce10@kernel.org>
Am Dienstag, 7. Februar 2023, 07:30:27 CET schrieb Jakub Kicinski:
> On Fri, 3 Feb 2023 14:21:02 +0100 Alexander Stein wrote:
> > The conversion to gpio descriptors accidentally removed the short return
> > if there is no 'phy-reset-gpios' property, leading to the error
> >
> > fec 30be0000.ethernet: error -ENOENT: failed to get phy-reset-gpios
> >
> > This is especially the case when the PHY reset GPIO is specified in
> > the PHY node itself.
> >
> > Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> > Signed-off-by: Alexander Stein <alexander.stein@ew•tq-group.com>
>
> Fixed around the same time by commit d7b5e5dd669436 right?
Yes, this does the trick as well. Thanks
Best regards
Alexander
prev parent reply other threads:[~2023-02-07 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:21 [PATCH 1/1] net: fec: Don't fail on missing optional phy-reset-gpios Alexander Stein
2023-02-07 6:30 ` Jakub Kicinski
2023-02-07 13:24 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21769138.EfDdHjke4D@steina-w \
--to=alexander.stein@ew$(echo .)tq-group.com \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-imx@nxp$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shenwei.wang@nxp$(echo .)com \
--cc=wei.fang@nxp$(echo .)com \
--cc=xiaoning.wang@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox