From: Eric Dumazet <eric.dumazet@gmail•com>
To: kbuild test robot <lkp@intel•com>, Eric Dumazet <edumazet@google•com>
Cc: kbuild-all@01•org, "David S . Miller" <davem@davemloft•net>,
netdev <netdev@vger•kernel.org>,
Soheil Hassas Yeganeh <soheil@google•com>,
Willem de Bruijn <willemb@google•com>,
Florian Westphal <fw@strlen•de>,
Tom Herbert <tom@herbertland•com>,
Eric Dumazet <eric.dumazet@gmail•com>
Subject: Re: [PATCH v2 net-next 3/3] tcp: add one skb cache for rx
Date: Fri, 22 Mar 2019 08:20:00 -0700 [thread overview]
Message-ID: <23f989f7-0cbd-c0dd-4591-ff452a0fc32a@gmail.com> (raw)
In-Reply-To: <201903222212.cZw1cpG1%lkp@intel.com>
On 03/22/2019 08:00 AM, kbuild test robot wrote:
> Hi Eric,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
>
> url: https://github.com/0day-ci/linux/commits/Eric-Dumazet/tcp-add-rx-tx-cache-to-reduce-lock-contention/20190322-215506
> config: x86_64-randconfig-x016-201911 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/dynamic_debug.h:6:0,
> from include/linux/printk.h:330,
> from include/linux/kernel.h:15,
> from include/linux/list.h:9,
> from include/linux/module.h:9,
> from drivers//net/ethernet/intel/e1000/e1000.h:10,
> from drivers//net/ethernet/intel/e1000/e1000_main.c:4:
> include/net/sock.h: In function 'sk_eat_skb':
>>> include/net/sock.h:2442:31: error: 'rps_needed' undeclared (first use in this function); did you mean 'free_netdev'?
> if (!static_branch_unlikely(&rps_needed) && !sk->sk_rx_skb_cache) {
> ^
> include/linux/jump_label.h:466:43: note: in definition of macro 'static_branch_unlikely'
> if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
> ^
> include/net/sock.h:2442:31: note: each undeclared identifier is reported only once for each function it appears in
> if (!static_branch_unlikely(&rps_needed) && !sk->sk_rx_skb_cache) {
> ^
> include/linux/jump_label.h:466:43: note: in definition of macro 'static_branch_unlikely'
> if (__builtin_types_compatible_p(typeof(*x), struct static_key_true)) \
> ^
>
> vim +2442 include/net/sock.h
>
> 2430
> 2431 /**
> 2432 * sk_eat_skb - Release a skb if it is no longer needed
> 2433 * @sk: socket to eat this skb from
> 2434 * @skb: socket buffer to eat
> 2435 *
> 2436 * This routine must be called with interrupts disabled or with the socket
> 2437 * locked so that the sk_buff queue operation is ok.
> 2438 */
> 2439 static inline void sk_eat_skb(struct sock *sk, struct sk_buff *skb)
> 2440 {
> 2441 __skb_unlink(skb, &sk->sk_receive_queue);
I guess all this makes sense on SMP systems only :)
>> 2442 if (!static_branch_unlikely(&rps_needed) && !sk->sk_rx_skb_cache) {
> 2443 sk->sk_rx_skb_cache = skb;
> 2444 skb_orphan(skb);
> 2445 return;
> 2446 }
> 2447 __kfree_skb(skb);
> 2448 }
> 2449
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next prev parent reply other threads:[~2019-03-22 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 0:14 [PATCH v2 net-next 0/3] tcp: add rx/tx cache to reduce lock contention Eric Dumazet
2019-03-22 0:14 ` [PATCH v2 net-next 1/3] net: convert rps_needed and rfs_needed to new static branch api Eric Dumazet
2019-03-22 0:14 ` [PATCH v2 net-next 2/3] tcp: add one skb cache for tx Eric Dumazet
2019-03-22 0:14 ` [PATCH v2 net-next 3/3] tcp: add one skb cache for rx Eric Dumazet
2019-03-22 14:57 ` kbuild test robot
2019-03-22 15:00 ` kbuild test robot
2019-03-22 15:20 ` Eric Dumazet [this message]
2019-03-22 1:54 ` [PATCH v2 net-next 0/3] tcp: add rx/tx cache to reduce lock contention Willem de Bruijn
2019-03-22 7:04 ` Soheil Hassas Yeganeh
2019-03-22 11:28 ` Michael S. Tsirkin
2019-03-22 12:49 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f989f7-0cbd-c0dd-4591-ff452a0fc32a@gmail.com \
--to=eric.dumazet@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=kbuild-all@01$(echo .)org \
--cc=lkp@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=soheil@google$(echo .)com \
--cc=tom@herbertland$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox