Subject: Re: [PATCH 1/2 v4] usbnet: allow status interrupt URB to always be active

From: Oliver Neukum <[email-masked]>
Date: Wed, 10 Apr 2013 15:31:58 +0200

On Wednesday 10 April 2013 15:25:49 Bjørn Mork wrote:
> Dan Williams <[email-masked]> writes:
> 
> > +int usbnet_status_start(struct usbnet *dev, gfp_t mem_flags)
> > +{
> > +	/* Only drivers that implement a status hook should call this */
> > +	BUG_ON(dev->interrupt == NULL);
> > 
> I still don't think there is any reason to BUG out. See for example
> http://article.gmane.org/gmane.linux.kernel/52102

On second consideration, yes, WARN_ON() would do the job.

	Regards
		Oliver