From: Wolfgang Walter <linux@stwm•de>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: David Miller <davem@davemloft•net>, Jerry Chu <hkchu@google•com>,
JesseGross <jesse@nicira•com>, Tom Herbert <tom@herbertland•com>,
netdev <netdev@vger•kernel.org>,
kernel-team@fb•com, Herbert Xu <herbert@gondor•apana.org.au>
Subject: Re: [PATCH net-next] ipv6: gro: support sit protocol
Date: Wed, 04 Nov 2015 15:09:17 +0100 [thread overview]
Message-ID: <2511200.aYIar34voW@stwm.de> (raw)
In-Reply-To: <1446640851.4184.20.camel@edumazet-glaptop2.roam.corp.google.com>
Am Mittwoch, 4. November 2015, 04:40:51 schrieb Eric Dumazet:
> On Wed, 2015-11-04 at 13:19 +0100, Wolfgang Walter wrote:
> > Today I found a problem: on a router forwarding GRE-packets (ipv4) (it is
> > not the endpount) the interface (intel igb) stops sending packets after
> > some time. I think this happens when an ISATAP packet is inside the
> > GRE-packet.>
> > gre packets arrives on eth0
> > eth1 stops sending (receiving still works)
> > ethtool -r eth1
> > eth1 works again for some time
> >
> > Switching GRO off on eth0 "fixes" the problem.
> >
> > I didn't test vanilla 4.1.12 yet, though. Until today 4.1.11 has been
> > running on the router. What I tested was your patch
> >
> > "gre_gso_segment() chokes if SIT frames were aggregated by GRO
engine."
> >
> > but did not solve the problem.
> >
> > So I would not recommend to backport it to longterm 4.1.
> >
> > My plans are:
> >
> > * test vanilla 4.1.12
> > * test 4.3
> >
> > I want to test 4.3 on another router first, though.
>
> If the NIC stops sending packets after some time, it might be an igb
> issue.
Yes, maybe igb has a problem sending a gro-packet if it is an isatap in gre.
igb has no problem sending gro-packets which are pure isatap or which are ipv4
(tcp/udp) in gre with 4.1.12 + these patches.
And it had no problem with 4.1.11 with isatap in gre.
Disabling gso for the interface does help.
I'll test pure 4.1.12 soon.
Regards,
--
Wolfgang Walter
Studentenwerk München
Anstalt des öffentlichen Rechts
next prev parent reply other threads:[~2015-11-04 14:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 17:11 [PATCH v2 net-next 0/4] gro: Fixes for tunnels and GRO Tom Herbert
2015-08-03 17:11 ` [PATCH v2 net-next 1/4] gro: Fix remcsum offload to deal with frags in GRO Tom Herbert
2015-08-03 17:11 ` [PATCH v2 net-next 2/4] vxlan: GRO support at tunnel layer Tom Herbert
2015-08-03 17:11 ` [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads Tom Herbert
2015-08-07 0:15 ` Jesse Gross
2015-10-16 15:23 ` Eric Dumazet
2015-10-20 2:04 ` Eric Dumazet
2015-10-20 3:40 ` [PATCH net-next] ipv6: gro: support sit protocol Eric Dumazet
2015-10-20 3:51 ` Tom Herbert
2015-10-22 2:37 ` David Miller
2015-11-03 12:57 ` Wolfgang Walter
2015-11-03 13:07 ` Eric Dumazet
2015-11-03 21:14 ` Tom Herbert
2015-11-04 12:19 ` Wolfgang Walter
2015-11-04 12:40 ` Eric Dumazet
2015-11-04 14:09 ` Wolfgang Walter [this message]
2015-11-04 15:13 ` Eric Dumazet
2015-11-04 17:05 ` Wolfgang Walter
2015-10-20 9:21 ` [PATCH v2 net-next 3/4] ipv6: Add gro functions to sit_offloads Wolfgang Walter
2015-08-03 17:11 ` [PATCH v2 net-next 4/4] fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks Tom Herbert
2015-08-07 1:55 ` [PATCH v2 net-next 0/4] gro: Fixes for tunnels and GRO David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2511200.aYIar34voW@stwm.de \
--to=linux@stwm$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hkchu@google$(echo .)com \
--cc=jesse@nicira$(echo .)com \
--cc=kernel-team@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=tom@herbertland$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox