Subject: Re: [PATCH v21 06/20] nvme-tcp: Add DDP data-path

From: Aurelien Aptel <[email-masked]>
Date: Mon, 18 Dec 2023 20:08:52 +0200

Max Gurtovoy <[email-masked]> writes:
>> +
>> +	if (nvme_tcp_is_ddp_offloaded(req)) {
>
> Same optimization here:
>
> if (IS_ENABLED(CONFIG_ULP_DDP) && nvme_tcp_is_ddp_offloaded(req)) {
>

nvme_tcp_is_ddp_offloaded() compiles to "return false" when ULP_DDP is
disabled and the compiler already folds the branching completely.

>
> if (IS_ENABLED(CONFIG_ULP_DDP) && test_bit(NVME_TCP_Q_OFF_DDP, 
> &queue->flags))
>

Same, I've checked and the test is already optimized out.

Thanks