Subject: Re: [PATCH v12 12/26] nvme-tcp: Only enable offload with TLS if the driver supports it

From: Aurelien Aptel <[email-masked]>
Date: Thu, 10 Aug 2023 17:52:03 +0300

Sagi Grimberg <[email-masked]> writes:
>> +     /* If we are using TLS and netdev doesn't support it, do not offload */
>> +     if (queue->ctrl->ctrl.opts->tls && !queue->ddp_limits.tls)
>> +             return false;
>
> Same for this, fold to the first patch.

Ok

> Other than that I had a question on one of my other responses.
> I don't think that tls_device supports 1.3, so what does tls
> here mean? That any device that enables this supports _all_
> tls versions?

This is a catch-all for all TLS versions.
We can split the logic between TLS version once a HW device will allow it.

Thanks