From: David Howells <dhowells@redhat•com>
To: Dan Carpenter <dan.carpenter@oracle•com>
Cc: dhowells@redhat•com, David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, kernel-janitors@vger•kernel.org
Subject: Re: [patch] RxRPC: use copy_to_user() instead of memcpy()
Date: Wed, 20 Mar 2013 10:23:38 +0000 [thread overview]
Message-ID: <27098.1363775018@warthog.procyon.org.uk> (raw)
In-Reply-To: <20130319225101.GZ9189@mwanda>
Dan Carpenter <dan.carpenter@oracle•com> wrote:
> Thanks for the explanation. I misread the code and then managed to
> trigger an unrelated locking bug and got confused.
>
> I think there is a spin_unlock(call->lock) missing somewhere on an
> error path. I have attached a reproducer file.
Are you running with lockdep enabled? That should catch such things.
David
next prev parent reply other threads:[~2013-03-20 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 10:55 [patch] RxRPC: use copy_to_user() instead of memcpy() Dan Carpenter
2013-03-19 13:42 ` David Miller
2013-03-19 13:59 ` David Howells
2013-03-19 22:51 ` Dan Carpenter
2013-03-20 10:23 ` David Howells [this message]
2013-03-20 15:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27098.1363775018@warthog.procyon.org.uk \
--to=dhowells@redhat$(echo .)com \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox