Subject: Re: [PATCH v7 13/24] wfx: add hif_tx*.c/hif_tx*.h

From: Jérôme Pouiller <[email-masked]>
Date: Fri, 01 Oct 2021 17:17:52 +0200

On Friday 1 October 2021 11:55:33 CEST Kalle Valo wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> Jerome Pouiller <[email-masked]> writes:
> 
> > From: Jérôme Pouiller <[email-masked]>
> >
> > Signed-off-by: Jérôme Pouiller <[email-masked]>
> 
> [...]
> 
> > --- /dev/null
> > +++ b/drivers/net/wireless/silabs/wfx/hif_tx_mib.h
> > @@ -0,0 +1,49 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Implementation of the host-to-chip MIBs of the hardware API.
> > + *
> > + * Copyright (c) 2017-2020, Silicon Laboratories, Inc.
> > + * Copyright (c) 2010, ST-Ericsson
> > + * Copyright (C) 2010, ST-Ericsson SA
> > + */
> > +#ifndef WFX_HIF_TX_MIB_H
> > +#define WFX_HIF_TX_MIB_H
> > +
> > +struct wfx_vif;
> > +struct sk_buff;
> > +
> > +int hif_set_output_power(struct wfx_vif *wvif, int val);
> > +int hif_set_beacon_wakeup_period(struct wfx_vif *wvif,
> > +                              unsigned int dtim_interval,
> > +                              unsigned int listen_interval);
> > +int hif_set_rcpi_rssi_threshold(struct wfx_vif *wvif,
> > +                             int rssi_thold, int rssi_hyst);
> > +int hif_get_counters_table(struct wfx_dev *wdev, int vif_id,
> > +                        struct hif_mib_extended_count_table *arg);
> > +int hif_set_macaddr(struct wfx_vif *wvif, u8 *mac);
> > +int hif_set_rx_filter(struct wfx_vif *wvif,
> > +                   bool filter_bssid, bool fwd_probe_req);
> > +int hif_set_beacon_filter_table(struct wfx_vif *wvif, int tbl_len,
> > +                             const struct hif_ie_table_entry *tbl);
> > +int hif_beacon_filter_control(struct wfx_vif *wvif,
> > +                           int enable, int beacon_count);
> > +int hif_set_operational_mode(struct wfx_dev *wdev, enum hif_op_power_mode mode);
> > +int hif_set_template_frame(struct wfx_vif *wvif, struct sk_buff *skb,
> > +                        u8 frame_type, int init_rate);
> > +int hif_set_mfp(struct wfx_vif *wvif, bool capable, bool required);
> > +int hif_set_block_ack_policy(struct wfx_vif *wvif,
> > +                          u8 tx_tid_policy, u8 rx_tid_policy);
> > +int hif_set_association_mode(struct wfx_vif *wvif, int ampdu_density,
> > +                          bool greenfield, bool short_preamble);
> > +int hif_set_tx_rate_retry_policy(struct wfx_vif *wvif,
> > +                              int policy_index, u8 *rates);
> > +int hif_keep_alive_period(struct wfx_vif *wvif, int period);
> > +int hif_set_arp_ipv4_filter(struct wfx_vif *wvif, int idx, __be32 *addr);
> > +int hif_use_multi_tx_conf(struct wfx_dev *wdev, bool enable);
> > +int hif_set_uapsd_info(struct wfx_vif *wvif, unsigned long val);
> > +int hif_erp_use_protection(struct wfx_vif *wvif, bool enable);
> > +int hif_slot_time(struct wfx_vif *wvif, int val);
> > +int hif_wep_default_key_id(struct wfx_vif *wvif, int val);
> > +int hif_rts_threshold(struct wfx_vif *wvif, int val);
> 
> "wfx_" prefix missing from quite a few functions.

I didn't know it was mandatory to prefix all the functions with the
same prefix. With the rule of 80-columns, I think I will have to change
a bunch of code :( .

-- 
Jérôme Pouiller