Subject: Re: [PATCH 3/4] GMAC: dts: add gmac info for rk3288

From: Heiko Stübner <[email-masked]>
Date: Wed, 26 Nov 2014 09:47:56 +0100

Am Mittwoch, 26. November 2014, 10:49:17 schrieb Roger:
> On 2014/11/25 22:39, Heiko Stübner wrote:
> > Am Dienstag, 25. November 2014, 16:40:59 schrieb Sergei Shtylyov:
> >> Hello.
> >> 
> >> On 11/25/2014 12:08 PM, Roger Chen wrote:
> >>> add gmac info in rk3288.dtsi for GMAC driver
> >>> 
> >>> Signed-off-by: Roger Chen <[email-masked]>
> >>> ---
> >>> 
> >>>    arch/arm/boot/dts/rk3288.dtsi |   59
> >>>    +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59
> >>>    insertions(+)
> >>> 
> >>> diff --git a/arch/arm/boot/dts/rk3288.dtsi
> >>> b/arch/arm/boot/dts/rk3288.dtsi
> >>> index 0f50d5d..949675d 100644
> >>> --- a/arch/arm/boot/dts/rk3288.dtsi
> >>> +++ b/arch/arm/boot/dts/rk3288.dtsi
> >> 
> >> [...]
> >> 
> >>> @@ -490,6 +497,25 @@
> >>> 
> >>>    		reg = <0xff740000 0x1000>;
> >>>    	
> >>>    	};
> >>> 
> >>> +	gmac: eth@ff290000 {
> >>> 
> >>      Please name the node "ethernet@ff290000" to comply with the ePAPR
> >> 
> >> standard.
> >> 
> >>> +		compatible = "rockchip,rk3288-gmac";
> >>> +		reg = <0xff290000 0x10000>;
> >>> +		interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;  /*irq=59*/
> >>> +		interrupt-names = "macirq";
> >>> +		rockchip,grf = <&grf>;
> >>> +		clocks = <&cru SCLK_MAC>, <&cru SCLK_MAC_PLL>,
> >>> +			<&cru SCLK_MAC_RX>, <&cru SCLK_MAC_TX>,
> >>> +			<&cru SCLK_MACREF>, <&cru SCLK_MACREF_OUT>,
> >>> +			<&cru ACLK_GMAC>, <&cru PCLK_GMAC>;
> >>> +		clock-names = "stmmaceth", "clk_mac_pll",
> >>> +			"mac_clk_rx", "mac_clk_tx",
> >>> +			"clk_mac_ref", "clk_mac_refout",
> >>> +			"aclk_mac", "pclk_mac";
> >>> +		phy-mode = "rgmii";
> >>> +		pinctrl-names = "default";
> >>> +		pinctrl-0 = <&rgmii_pin /*&rmii_pin*/>;
> >>> 
> >>      Hm, pinctrl props in a .dtsi file? Those are usually board
> >>      dependent.
> > 
> > yep, especially as there is a board-dependent selection needed of what to
> > use [rgmii or rmii] depending on the phy on the board.
> 
> of course pinctrl props is redefined in the rk3288-evb-rk808.dts,
> IMO, pinctrl props in .dtsi is used to fit for the "phy-mode" prop as
> default. if pinctrl props should be removed, how about "phy-mode" prop?

yep, the phy-mode should also move to the board file - as it of course also 
depends on the phy-chip used there.