From: Jesper Dangaard Brouer <hawk@kernel•org>
To: "Jakub Kicinski" <kuba@kernel•org>,
"Eric Dumazet" <eric.dumazet@gmail•com>,
"Toke Høiland-Jørgensen" <toke@toke•dk>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
bpf@vger•kernel.org, horms@kernel•org, jiri@resnulli•us,
edumazet@google•com, xiyou.wangcong@gmail•com, jhs@mojatatu•com,
carges@cloudflare•com, kernel-team@cloudflare•com
Subject: Re: [PATCH net-next RFC v1 0/3] net: sched: refactor qdisc drop reasons into dedicated tracepoint
Date: Thu, 5 Feb 2026 09:48:43 +0100 [thread overview]
Message-ID: <2e1eb11c-cd47-4772-baff-45d43d4fa539@kernel.org> (raw)
In-Reply-To: <20260204190417.110f5498@kernel.org>
On 05/02/2026 04.04, Jakub Kicinski wrote:
> On Wed, 04 Feb 2026 18:02:49 +0100 Jesper Dangaard Brouer wrote:
>> RFC: Seeking feedback on this refactoring approach.
>>
>> This series refactors qdisc drop reason handling by introducing a dedicated
>> enum qdisc_drop_reason and trace_qdisc_drop tracepoint, providing qdisc
>> layer drop diagnostics with direct qdisc context visibility.
>
> I like this!
Awesome, then I will continue in this direction :-)
> It will presumably require existing users to migrate over
> but sooner we do it the fewer users that have to move?
I agree. Existing users will loose some details, but the patchset
results in fallback to SKB_DROP_REASON_QDISC_DROP as a drop reason,
which existing tools/users will still handle.
(The more specific drop reason is now avail via trace_qdisc_drop).
Eric and Toke is this acceptable for your users?
In patch 1/3 I kept the qdisc "name" as part of the enum for FQ and
CAKE. IMHO this should be changed for next patchset, but I offer you the
chance to review and suggest generic naming (else I will choose).
--Jesper
next prev parent reply other threads:[~2026-02-05 8:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 17:02 [PATCH net-next RFC v1 0/3] net: sched: refactor qdisc drop reasons into dedicated tracepoint Jesper Dangaard Brouer
2026-02-04 17:02 ` [PATCH net-next RFC v1 1/3] net: sched: introduce qdisc-specific drop reason tracing Jesper Dangaard Brouer
2026-02-04 17:03 ` [PATCH net-next RFC v1 2/3] net: sched: sfq: convert to qdisc drop reasons Jesper Dangaard Brouer
2026-02-04 17:03 ` [PATCH net-next RFC v1 3/3] net: sched: sch_cake: use enum qdisc_drop_reason for cobalt_should_drop Jesper Dangaard Brouer
2026-02-05 3:04 ` [PATCH net-next RFC v1 0/3] net: sched: refactor qdisc drop reasons into dedicated tracepoint Jakub Kicinski
2026-02-05 8:48 ` Jesper Dangaard Brouer [this message]
2026-02-05 11:34 ` Toke Høiland-Jørgensen
2026-02-05 14:15 ` Antoine Tenart
2026-02-05 14:46 ` Toke Høiland-Jørgensen
2026-02-05 16:24 ` Antoine Tenart
2026-02-06 14:41 ` Jesper Dangaard Brouer
2026-02-06 15:04 ` Antoine Tenart
2026-02-06 15:21 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e1eb11c-cd47-4772-baff-45d43d4fa539@kernel.org \
--to=hawk@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=carges@cloudflare$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kernel-team@cloudflare$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=toke@toke$(echo .)dk \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox