public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: xiaofeis@codeaurora•org
To: Andrew Lunn <andrew@lunn•ch>
Cc: vkoul@kernel•org, netdev <netdev@vger•kernel.org>
Subject: Re: [PATCH v2] net: dsa: qca8k: enable port flow control
Date: Sat, 27 Jul 2019 09:15:56 +0800	[thread overview]
Message-ID: <2e2b0d3962d387046ae430be61acbf44@codeaurora.org> (raw)
In-Reply-To: <20190726132919.GB18223@lunn.ch>

On 2019-07-26 21:29, Andrew Lunn wrote:
>> I didn't compile it on this tree, same code is just compiled and 
>> tested on
>> kernel v4.14.
> 
> For kernel development work, v4.14 is dead. It died 12th November
> 2017. It gets backports of bug fixes, but kernel developers otherwise
> don't touch it.
> 
>> We are working on one google project, all the change is
>> required to upstream by Google.
>> But if I do the change based on the new type for kernel 5.3, then the 
>> commit
>> can't be used directly for Google's project.
> 
> So you will need to backport the change. In this case, you will have a
> very different patch in v4.14 than in mainline, due to changes like
> this. That is part of the pain in using such an old kernel.
> 
> You should use the function
> 
> void phy_support_asym_pause(struct phy_device *phydev);
> 
> to indicate the MAC supports asym pause.
> 
>    Andrew

Hi Andrew

Thanks a lot, you are correct. phy_support_asym_pause is the API to do 
this.

Very appreciate for all your patinet explaination and good suggestion.

Thanks
Xiaofeis

     prev parent reply	other threads:[~2019-07-27  1:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-24  5:02 [PATCH v2] net: dsa: qca8k: enable port flow control xiaofeis
2019-07-24 17:05 ` kbuild test robot
2019-07-24 17:50 ` Andrew Lunn
     [not found]   ` <351b5292d597e47d69d0dcfd5af6a188@codeaurora.org>
     [not found]     ` <20190725130135.GA21952@lunn.ch>
     [not found]       ` <e2c51913e0e38450b09ef8f06bf259c0@codeaurora.org>
2019-07-26 13:29         ` Andrew Lunn
2019-07-27  1:15           ` xiaofeis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e2b0d3962d387046ae430be61acbf44@codeaurora.org \
    --to=xiaofeis@codeaurora$(echo .)org \
    --cc=andrew@lunn$(echo .)ch \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=vkoul@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox