From: Shuah Khan <skhan@linuxfoundation•org>
To: Muhammad Usama Anjum <usama.anjum@collabora•com>,
Sherry Yang <sherry.yang@oracle•com>
Cc: "shuah@kernel•org" <shuah@kernel•org>,
Kees Cook <keescook@chromium•org>,
"luto@amacapital•net" <luto@amacapital•net>,
"wad@chromium•org" <wad@chromium•org>,
"christian@brauner•io" <christian@brauner•io>,
"ast@kernel•org" <ast@kernel•org>,
"daniel@iogearbox•net" <daniel@iogearbox•net>,
"andrii@kernel•org" <andrii@kernel•org>,
"kafai@fb•com" <kafai@fb•com>,
"songliubraving@fb•com" <songliubraving@fb•com>,
"yhs@fb•com" <yhs@fb•com>,
"john.fastabend@gmail•com" <john.fastabend@gmail•com>,
"kpsingh@kernel•org" <kpsingh@kernel•org>,
"linux-kselftest@vger•kernel.org"
<linux-kselftest@vger•kernel.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"bpf@vger•kernel.org" <bpf@vger•kernel.org>,
Shuah Khan <skhan@linuxfoundation•org>
Subject: Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers
Date: Tue, 15 Feb 2022 11:43:48 -0700 [thread overview]
Message-ID: <2f59f86c-dbd7-7dbf-021d-bc62ebbe2a43@linuxfoundation.org> (raw)
In-Reply-To: <4b739847-0622-c221-33b3-9fe428a52bc0@collabora.com>
On 2/15/22 11:17 AM, Muhammad Usama Anjum wrote:
>
> On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote:
>>>> "../../../../usr/include/" directory doesn't have header files if
>>>> different output directory is used for kselftests build like "make -C
>>>> tools/tests/selftest O=build". Can you try adding recently added
>>>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
>>>> easy and correct for other build combinations as well?
>>>>
>>>>
>>>
>>> Hi Muhammad,
>>>
>>> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice
>>> work! I really appreciate you made headers inclusion compatible. However,
>>> my case is a little more complicated. It will throw warnings with -I, using
>>> -isystem can suppress these warnings, more details please refer to
>>> https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
>>>
>>> According to this case, do you think will it be better to export header path
>>> (KHDR_INCLUDES) without “-I”?
>> Well said. I've thought about it and it seems like -isystem is better
>> than -I. I've sent a patch:
>> https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/
>> I'm looking forward to discussion on it.
> The patch has been accepted. It should appear in linux-next soon. You
> should be able to use KHDR_INCLUDES easily now.
>
Sherry,
I pulled in your patch as a fix as is for 5.17-rc5.
Using KHDR_INCLUDES can be separate patch for next release.
This way the fix is going to be pulled for this release
without dependencies on other patches.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-02-15 18:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 20:30 [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers Sherry Yang
2022-02-10 21:16 ` Kees Cook
2022-02-10 21:36 ` Shuah Khan
2022-02-10 23:11 ` Muhammad Usama Anjum
2022-02-10 23:14 ` Muhammad Usama Anjum
2022-02-10 23:58 ` Kees Cook
2022-02-11 1:14 ` Sherry Yang
2022-02-14 16:12 ` Muhammad Usama Anjum
2022-02-15 18:17 ` Muhammad Usama Anjum
2022-02-15 18:43 ` Shuah Khan [this message]
2022-02-15 18:51 ` Sherry Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f59f86c-dbd7-7dbf-021d-bc62ebbe2a43@linuxfoundation.org \
--to=skhan@linuxfoundation$(echo .)org \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=christian@brauner$(echo .)io \
--cc=daniel@iogearbox$(echo .)net \
--cc=john.fastabend@gmail$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kpsingh@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=luto@amacapital$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sherry.yang@oracle$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=songliubraving@fb$(echo .)com \
--cc=usama.anjum@collabora$(echo .)com \
--cc=wad@chromium$(echo .)org \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox