Subject: Re: [PATCH net v3 0/4] Unsync addresses from ports when stopping aggregated devices

From: Jay Vosburgh <[email-masked]>
Date: Thu, 08 Sep 2022 16:25:43 -0700

Benjamin Poirier <[email-masked]> wrote:

>This series fixes similar problems in the bonding and team drivers.
>
>Because of missing dev_{uc,mc}_unsync() calls, addresses added to
>underlying devices may be leftover after the aggregated device is deleted.
>Add the missing calls and a few related tests.

	I'm not seeing any gaps in the logic; so, for the bonding parts
of the series

Acked-by: Jay Vosburgh <[email-masked]>

	-J

>v2:
>* fix selftest installation, see patch 3
>
>v3:
>* Split lacpdu_multicast changes to their own patch, #1
>* In ndo_{add,del}_slave methods, only perform address list changes when
>  the aggregated device is up (patches 2 & 3)
>* Add selftest function related to the above change (patch 4)
>
>Benjamin Poirier (4):
>  net: bonding: Share lacpdu_mcast_addr definition
>  net: bonding: Unsync device addresses on ndo_stop
>  net: team: Unsync device addresses on ndo_stop
>  net: Add tests for bonding and team address list management
>
> MAINTAINERS                                   |   1 +
> drivers/net/bonding/bond_3ad.c                |   5 +-
> drivers/net/bonding/bond_main.c               |  57 +++++----
> drivers/net/team/team.c                       |  24 +++-
> include/net/bond_3ad.h                        |   2 -
> include/net/bonding.h                         |   3 +
> tools/testing/selftests/Makefile              |   1 +
> .../selftests/drivers/net/bonding/Makefile    |   5 +-
> .../selftests/drivers/net/bonding/config      |   1 +
> .../drivers/net/bonding/dev_addr_lists.sh     | 109 ++++++++++++++++++
> .../selftests/drivers/net/bonding/lag_lib.sh  |  61 ++++++++++
> .../selftests/drivers/net/team/Makefile       |   6 +
> .../testing/selftests/drivers/net/team/config |   3 +
> .../drivers/net/team/dev_addr_lists.sh        |  51 ++++++++
> 14 files changed, 297 insertions(+), 32 deletions(-)
> create mode 100755 tools/testing/selftests/drivers/net/bonding/dev_addr_lists.sh
> create mode 100644 tools/testing/selftests/drivers/net/bonding/lag_lib.sh
> create mode 100644 tools/testing/selftests/drivers/net/team/Makefile
> create mode 100644 tools/testing/selftests/drivers/net/team/config
> create mode 100755 tools/testing/selftests/drivers/net/team/dev_addr_lists.sh
>
>-- 
>2.37.2
>

---
	-Jay Vosburgh, [email-masked]