From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel•com>
To: Jakub Kicinski <kuba@kernel•org>,
Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: <davem@davemloft•net>, <pabeni@redhat•com>, <edumazet@google•com>,
<netdev@vger•kernel.org>, <jacob.e.keller@intel•com>,
<jiri@nvidia•com>, <idosch@idosch•org>
Subject: Re: [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver
Date: Mon, 13 Feb 2023 15:46:53 -0800 [thread overview]
Message-ID: <319b4a93-bdaf-e619-b7ae-2293b2df0cca@intel.com> (raw)
In-Reply-To: <20230210202358.6a2e890b@kernel.org>
On 2/10/2023 8:23 PM, Jakub Kicinski wrote:
> Can you describe how this is used a little bit?
> The FW log is captured at some level always (e.g. warns)
> or unless user enables _nothing_ will come out?
>
My understanding is that the FW is constantly logging data into internal
buffers. When the user indicates what data they want and what level they
want then the data is filtered and output via either the UART or the
Admin queues. These patches retrieve the FW logs via the admin queue
commands.
The output from the FW is a binary blob that a user would send back to
Intel to be decoded. This is only used for troubleshooting issues where
a user is working with someone from Intel on a specific problem.
Does that help?
> On Thu, 9 Feb 2023 11:06:57 -0800 Tony Nguyen wrote:
>> devlink dev param set <pci dev> name fwlog_enabled value <true/false> cmode runtime
>> devlink dev param set <pci dev> name fwlog_level value <0-4> cmode runtime
>> devlink dev param set <pci dev> name fwlog_resolution value <1-128> cmode runtime
>
> If you're using debugfs as a pipe you should put these enable knobs
> in there as well.
My understanding is that debugfs use as a write mechanism is frowned on.
If that's not true and if we were to submit patches that used debugfs
instead of devlink and they would be accepted then I'll happily do that. :)
Or add a proper devlink command to carry all this
> information via structured netlink (fw log + level + enable are hardly
> Intel specific).
I don't know how other companies FW interface works so wouldn't assume
that I could come up with an interface that would work across all devices.
Paul
next prev parent reply other threads:[~2023-02-13 23:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 19:06 [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver Tony Nguyen
2023-02-09 19:06 ` [PATCH net-next 1/5] ice: remove FW logging code Tony Nguyen
2023-02-09 19:06 ` [PATCH net-next 2/5] ice: enable devlink to check FW logging status Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 3/5] ice: add ability to query/set FW log level and resolution Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 4/5] ice: disable FW logging on driver unload Tony Nguyen
2023-02-09 19:07 ` [PATCH net-next 5/5] ice: use debugfs to output FW log data Tony Nguyen
2023-02-11 4:23 ` [PATCH net-next 0/5][pull request] add v2 FW logging for ice driver Jakub Kicinski
2023-02-13 23:46 ` Paul M Stillwell Jr [this message]
2023-02-14 0:40 ` Jakub Kicinski
2023-02-14 16:14 ` Paul M Stillwell Jr
2023-02-14 20:44 ` Jakub Kicinski
2023-02-14 22:39 ` Jacob Keller
2023-02-14 23:19 ` Jakub Kicinski
2023-02-15 0:07 ` Jacob Keller
2023-02-15 1:16 ` Jakub Kicinski
2023-02-15 1:33 ` Jacob Keller
2023-02-15 2:07 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=319b4a93-bdaf-e619-b7ae-2293b2df0cca@intel.com \
--to=paul.m.stillwell.jr@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=idosch@idosch$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox