From: "Samudrala, Sridhar" <sridhar.samudrala@intel•com>
To: Stephen Hemminger <stephen@networkplumber•org>
Cc: mst@redhat•com, davem@davemloft•net, netdev@vger•kernel.org,
virtualization@lists•linux-foundation.org,
virtio-dev@lists•oasis-open.org, jesse.brandeburg@intel•com,
alexander.h.duyck@intel•com, kubakici@wp•pl, jasowang@redhat•com,
loseweigh@gmail•com, jiri@resnulli•us, aaron.f.brown@intel•com,
anjali.singhai@intel•com
Subject: Re: [PATCH net-next v12 1/5] net: Introduce generic failover module
Date: Wed, 30 May 2018 19:58:30 -0700 [thread overview]
Message-ID: <32eb5af0-d052-5e30-e065-e362df31ba4a@intel.com> (raw)
In-Reply-To: <20180530225259.2cf3f7be@shemminger-XPS-13-9360>
On 5/30/2018 7:52 PM, Stephen Hemminger wrote:
> On Fri, 25 May 2018 16:06:58 -0700
> "Samudrala, Sridhar" <sridhar.samudrala@intel•com> wrote:
>
>> On 5/25/2018 3:38 PM, Stephen Hemminger wrote:
>>> On Thu, 24 May 2018 09:55:13 -0700
>>> Sridhar Samudrala <sridhar.samudrala@intel•com> wrote:
>>>
>>>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>>>> index 03ed492c4e14..0f4ba52b641d 100644
>>>> --- a/include/linux/netdevice.h
>>>> +++ b/include/linux/netdevice.h
>>>> @@ -1421,6 +1421,8 @@ struct net_device_ops {
>>>> * entity (i.e. the master device for bridged veth)
>>>> * @IFF_MACSEC: device is a MACsec device
>>>> * @IFF_NO_RX_HANDLER: device doesn't support the rx_handler hook
>>>> + * @IFF_FAILOVER: device is a failover master device
>>>> + * @IFF_FAILOVER_SLAVE: device is lower dev of a failover master device
>>>> */
>>>> enum netdev_priv_flags {
>>>> IFF_802_1Q_VLAN = 1<<0,
>>>> @@ -1450,6 +1452,8 @@ enum netdev_priv_flags {
>>>> IFF_PHONY_HEADROOM = 1<<24,
>>>> IFF_MACSEC = 1<<25,
>>>> IFF_NO_RX_HANDLER = 1<<26,
>>>> + IFF_FAILOVER = 1<<27,
>>>> + IFF_FAILOVER_SLAVE = 1<<28,
>>>> };
>>> Why is FAILOVER any different than other master/slave relationships.
>>> I don't think you need to take up precious netdev flag bits for this.
>> These are netdev priv flags.
>> Jiri says that IFF_MASTER/IFF_SLAVE are bonding specific flags and cannot be used
>> with other failover mechanisms. Team also doesn't use this flags and it has its own
>> priv_flags.
>>
> This change breaks userspace.
> We already have worked with partners to ignore devices marked as IFF_SLAVE,
> and IFF_SLAVE is visible to user space API's.
I specifically made sure not to remove IFF_SLAVE in the netvsc patch.
>
> NAK
next prev parent reply other threads:[~2018-05-31 2:58 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-24 16:55 [PATCH net-next v12 0/5] Enable virtio_net to act as a standby for a passthru device Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 1/5] net: Introduce generic failover module Sridhar Samudrala
2018-05-25 22:37 ` Stephen Hemminger
2018-05-25 23:04 ` Samudrala, Sridhar
2018-05-26 7:43 ` Jiri Pirko
2018-05-25 22:38 ` Stephen Hemminger
2018-05-25 23:06 ` Samudrala, Sridhar
2018-05-25 23:29 ` Stephen Hemminger
2018-05-31 2:52 ` Stephen Hemminger
2018-05-31 2:58 ` Samudrala, Sridhar [this message]
2018-05-24 16:55 ` [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework Sridhar Samudrala
2018-05-25 22:34 ` Stephen Hemminger
2018-05-25 23:11 ` Samudrala, Sridhar
2018-05-25 23:28 ` Stephen Hemminger
2018-05-26 7:22 ` Samudrala, Sridhar
2018-05-26 7:51 ` Jiri Pirko
2018-05-26 19:22 ` Samudrala, Sridhar
2018-05-31 2:06 ` Stephen Hemminger
2018-05-31 3:03 ` Samudrala, Sridhar
2018-05-31 12:58 ` Stephen Hemminger
2018-05-31 17:34 ` Michael S. Tsirkin
2018-05-31 18:35 ` Michael S. Tsirkin
2018-05-31 20:41 ` Siwei Liu
2018-05-24 16:55 ` [PATCH net-next v12 3/5] net: Introduce net_failover driver Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 4/5] virtio_net: Introduce VIRTIO_NET_F_STANDBY feature bit Sridhar Samudrala
2018-05-24 16:55 ` [PATCH net-next v12 5/5] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-05-25 17:19 ` [PATCH net-next v12 0/5] Enable virtio_net to act as a standby for a passthru device Michael S. Tsirkin
2018-05-29 3:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32eb5af0-d052-5e30-e065-e362df31ba4a@intel.com \
--to=sridhar.samudrala@intel$(echo .)com \
--cc=aaron.f.brown@intel$(echo .)com \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=anjali.singhai@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jasowang@redhat$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kubakici@wp$(echo .)pl \
--cc=loseweigh@gmail$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=virtio-dev@lists$(echo .)oasis-open.org \
--cc=virtualization@lists$(echo .)linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox