From: Florian Fainelli <f.fainelli@gmail•com>
To: Asmaa Mnebhi <asmaa@nvidia•com>,
davem@davemloft•net, linux@armlinux•org.uk,
netdev@vger•kernel.org
Cc: davthompson@nvidia•com
Subject: Re: [PATCH v1 1/1] net: phy: micrel: Add workaround for incomplete autonegotiation
Date: Fri, 19 Jan 2024 15:14:11 -0800 [thread overview]
Message-ID: <33bbf54f-06dc-4e80-b5ac-adaf7855ee3f@gmail.com> (raw)
In-Reply-To: <20231226141903.12040-1-asmaa@nvidia.com>
On 12/26/23 06:19, Asmaa Mnebhi wrote:
> Very rarely, the KSZ9031 fails to complete autonegotiation although it was
> initiated via phy_start(). As a result, the link stays down. Restarting
> autonegotiation when in this state solves the issue.
>
> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia•com>
We used to have a link_timeout as well as the PHY_HAS_MAGICANEG logic in
the PHY library a long time ago:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?id=00db8189d984d6c51226dafbbe4a667ce9b7d5da
maybe you can schedule a work queue in case you are using interrupts to
re-check the link status periodically?
--
Florian
prev parent reply other threads:[~2024-01-19 23:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 14:19 [PATCH v1 1/1] net: phy: micrel: Add workaround for incomplete autonegotiation Asmaa Mnebhi
2023-12-27 22:19 ` Marek Mojík
2024-01-02 18:45 ` Russell King (Oracle)
2024-01-03 1:27 ` Andrew Lunn
2024-01-19 18:11 ` Asmaa Mnebhi
2024-01-19 19:44 ` Andrew Lunn
2024-01-19 19:56 ` Andrew Lunn
2024-01-19 20:18 ` Asmaa Mnebhi
2024-01-19 22:38 ` Andrew Lunn
2024-01-19 22:57 ` Asmaa Mnebhi
2024-01-24 22:18 ` Asmaa Mnebhi
2024-01-19 23:14 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33bbf54f-06dc-4e80-b5ac-adaf7855ee3f@gmail.com \
--to=f.fainelli@gmail$(echo .)com \
--cc=asmaa@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=davthompson@nvidia$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox