Subject: Re: [PATCH net-next 1/6] net: stmmac: rk: introduce flags indicating support for RGMII/RMII

From: Heiko Stübner <[email-masked]>
Date: Wed, 04 Feb 2026 20:57:13 +0100

Am Mittwoch, 4. Februar 2026, 10:14:17 Mitteleuropäische Normalzeit schrieb Russell King (Oracle):
> Introduce two boolean flags into struct rk_priv_data indicating
> whether RGMII and/or RMII is supported for this instance. Use these
> to configure the supported_interfaces mask for phylink, validate the
> interface mode. Initialise these from equivalent flags in the
> rk_gmac_ops or depending on the presence of the ops->set_to_rgmii and
> ops->set_to_mii methods. Finally, make ops->set_to_* optional.
> 
> This will allow us to get rid of empty set_to_rmii() methods.
> 
> Signed-off-by: Russell King (Oracle) <[email-masked]>

Reviewed-by: Heiko Stuebner <[email-masked]>
Tested-by: Heiko Stuebner <[email-masked]> #px30,rk3328,rk3568,rk3588