Subject: RE: handling MAC set by user space in reset_resume() of r8152

From: Hayes Wang <[email-masked]>
Date: Thu, 28 Jul 2022 08:40:16 +0000

Oliver Neukum <[email-masked]>
> > Date: Wed, 27 Jul 2022 13:29:42 +0200
> > Subject: [PATCH] r8152: restore external MAC in reset_resume
> >
> > If user space has set the MAC of the interface,
> > reset_resume() must restore that setting rather
> > than redetermine the MAC like if te interface
> > is probed regularly.

I think this patch conflicts with commit 25766271e42f ("r8152: Refresh
MAC address during USBDEVFS_RESET"). The results would be changed.

Besides, I don't understand why you set tp->external_mac = false
in rtl8152_down().

Best Regards,
Hayes