From: William Zhang <william.zhang@broadcom•com>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd•com>,
broonie@kernel•org, miquel.raynal@bootlin•com, richard@nod•at,
vigneshr@ti•com, jic23@kernel•org, tudor.ambarus@microchip•com,
pratyush@kernel•org, sanju.mehta@amd•com,
chin-ting_kuo@aspeedtech•com, clg@kaod•org, kdasu.kdev@gmail•com,
f.fainelli@gmail•com, rjui@broadcom•com, sbranden@broadcom•com,
eajames@linux•ibm.com, olteanv@gmail•com, han.xu@nxp•com,
john.garry@huawei•com, shawnguo@kernel•org,
s.hauer@pengutronix•de, narmstrong@baylibre•com,
khilman@baylibre•com, matthias.bgg@gmail•com, haibo.chen@nxp•com,
linus.walleij@linaro•org, daniel@zonque•org,
haojian.zhuang@gmail•com, robert.jarzmik@free•fr,
agross@kernel•org, bjorn.andersson@linaro•org, heiko@sntech•de,
krzysztof.kozlowski@linaro•org, andi@etezian•org,
mcoquelin.stm32@gmail•com, alexandre.torgue@foss•st.com,
wens@csie•org, jernej.skrabec@gmail•com, samuel@sholland•org,
masahisa.kojima@linaro•org, jaswinder.singh@linaro•org,
rostedt@goodmis•org, mingo@redhat•com, l.stelmach@samsung•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, alex.aring@gmail•com,
stefan@datenfreihafen•org, kvalo@kernel•org,
thierry.reding@gmail•com, jonathanh@nvidia•com,
skomatineni@nvidia•com, sumit.semwal@linaro•org,
christian.koenig@amd•com, j.neuschaefer@gmx•net,
vireshk@kernel•org, rmfrfs@gmail•com, johan@kernel•org,
elder@kernel•org, gregkh@linuxfoundation•org
Cc: git@amd•com, linux-spi@vger•kernel.org,
linux-kernel@vger•kernel.org, joel@jms•id.au, andrew@aj•id.au,
radu_nicolae.pirea@upb•ro, nicolas.ferre@microchip•com,
alexandre.belloni@bootlin•com, claudiu.beznea@microchip•com,
bcm-kernel-feedback-list@broadcom•com, fancer.lancer@gmail•com,
kernel@pengutronix•de, festevam@gmail•com, linux-imx@nxp•com,
jbrunet@baylibre•com, martin.blumenstingl@googlemail•com,
avifishman70@gmail•com, tmaimon77@gmail•com,
tali.perry1@gmail•com, venture@google•com, yuenn@google•com,
benjaminfair@google•com, yogeshgaur.83@gmail•com,
konrad.dybcio@somainline•org, alim.akhtar@samsung•com,
ldewangan@nvidia•com, michal.simek@amd•com,
linux-aspeed@lists•ozlabs.org, openbmc@lists•ozlabs.org,
linux-arm-kernel@lists•infradead.org,
linux-rpi-kernel@lists•infradead.org,
linux-amlogic@lists•infradead.org,
linux-mediatek@lists•infradead.org,
linux-arm-msm@vger•kernel.org,
linux-rockchip@lists•infradead.org,
linux-samsung-soc@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-sunxi@lists•linux.dev, linux-tegra@vger•kernel.org,
netdev@vger•kernel.org, linux-wpan@vger•kernel.org,
libertas-dev@lists•infradead.org, linux-wireless@vger•kernel.org,
linux-mtd@lists•infradead.org, lars@metafoo•de,
Michael.Hennerich@analog•com, linux-iio@vger•kernel.org,
michael@walle•cc, palmer@dabbelt•com,
linux-riscv@lists•infradead.org, linux-media@vger•kernel.org,
dri-devel@lists•freedesktop.org, greybus-dev@lists•linaro.org,
linux-staging@lists•linux.dev, amitrkcian2002@gmail•com
Subject: Re: [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call
Date: Tue, 24 Jan 2023 16:57:49 -0800 [thread overview]
Message-ID: <36840e0caeca5f53eef4fab615fc7976@mail.gmail.com> (raw)
In-Reply-To: <20230119185342.2093323-3-amit.kumar-mahapatra@amd.com>
[-- Attachment #1: Type: text/plain, Size: 3732 bytes --]
On 01/19/2023 10:53 AM, 'Amit Kumar Mahapatra' via
BCM-KERNEL-FEEDBACK-LIST,PDL wrote:
> diff --git a/drivers/spi/spi-bcm63xx-hsspi.c
> b/drivers/spi/spi-bcm63xx-hsspi.c
> index b871fd810d80..dc179c4677d4 100644
> --- a/drivers/spi/spi-bcm63xx-hsspi.c
> +++ b/drivers/spi/spi-bcm63xx-hsspi.c
> @@ -130,7 +130,7 @@ static void bcm63xx_hsspi_set_cs(struct bcm63xx_hsspi
> *bs, unsigned int cs,
> static void bcm63xx_hsspi_set_clk(struct bcm63xx_hsspi *bs,
> struct spi_device *spi, int hz)
> {
> - unsigned int profile = spi->chip_select;
> + unsigned int profile = spi_get_chipselect(spi, 0);
> u32 reg;
>
> reg = DIV_ROUND_UP(2048, DIV_ROUND_UP(bs->speed_hz, hz));
> @@ -157,7 +157,7 @@ static void bcm63xx_hsspi_set_clk(struct bcm63xx_hsspi
> *bs,
> static int bcm63xx_hsspi_do_txrx(struct spi_device *spi, struct
> spi_transfer *t)
> {
> struct bcm63xx_hsspi *bs = spi_master_get_devdata(spi->master);
> - unsigned int chip_select = spi->chip_select;
> + unsigned int chip_select = spi_get_chipselect(spi, 0);
> u16 opcode = 0;
> int pending = t->len;
> int step_size = HSSPI_BUFFER_LEN;
> @@ -165,7 +165,7 @@ static int bcm63xx_hsspi_do_txrx(struct spi_device
> *spi, struct spi_transfer *t)
> u8 *rx = t->rx_buf;
>
> bcm63xx_hsspi_set_clk(bs, spi, t->speed_hz);
> - bcm63xx_hsspi_set_cs(bs, spi->chip_select, true);
> + bcm63xx_hsspi_set_cs(bs, spi_get_chipselect(spi, 0), true);
>
> if (tx && rx)
> opcode = HSSPI_OP_READ_WRITE;
> @@ -228,14 +228,14 @@ static int bcm63xx_hsspi_setup(struct spi_device
> *spi)
> u32 reg;
>
> reg = __raw_readl(bs->regs +
> - HSSPI_PROFILE_SIGNAL_CTRL_REG(spi->chip_select));
> + HSSPI_PROFILE_SIGNAL_CTRL_REG(spi_get_chipselect(spi, 0)));
> reg &= ~(SIGNAL_CTRL_LAUNCH_RISING | SIGNAL_CTRL_LATCH_RISING);
> if (spi->mode & SPI_CPHA)
> reg |= SIGNAL_CTRL_LAUNCH_RISING;
> else
> reg |= SIGNAL_CTRL_LATCH_RISING;
> __raw_writel(reg, bs->regs +
> - HSSPI_PROFILE_SIGNAL_CTRL_REG(spi->chip_select));
> + HSSPI_PROFILE_SIGNAL_CTRL_REG(spi_get_chipselect(spi, 0)));
>
> mutex_lock(&bs->bus_mutex);
> reg = __raw_readl(bs->regs + HSSPI_GLOBAL_CTRL_REG);
> @@ -243,16 +243,16 @@ static int bcm63xx_hsspi_setup(struct spi_device
> *spi)
> /* only change actual polarities if there is no transfer */
> if ((reg & GLOBAL_CTRL_CS_POLARITY_MASK) == bs->cs_polarity) {
> if (spi->mode & SPI_CS_HIGH)
> - reg |= BIT(spi->chip_select);
> + reg |= BIT(spi_get_chipselect(spi, 0));
> else
> - reg &= ~BIT(spi->chip_select);
> + reg &= ~BIT(spi_get_chipselect(spi, 0));
> __raw_writel(reg, bs->regs + HSSPI_GLOBAL_CTRL_REG);
> }
>
> if (spi->mode & SPI_CS_HIGH)
> - bs->cs_polarity |= BIT(spi->chip_select);
> + bs->cs_polarity |= BIT(spi_get_chipselect(spi, 0));
> else
> - bs->cs_polarity &= ~BIT(spi->chip_select);
> + bs->cs_polarity &= ~BIT(spi_get_chipselect(spi, 0));
>
> mutex_unlock(&bs->bus_mutex);
>
> @@ -283,7 +283,7 @@ static int bcm63xx_hsspi_transfer_one(struct
> spi_master *master,
> * e. At the end restore the polarities again to their default values.
> */
>
> - dummy_cs = !spi->chip_select;
> + dummy_cs = !spi_get_chipselect(spi, 0);
> bcm63xx_hsspi_set_cs(bs, dummy_cs, true);
>
> list_for_each_entry(t, &msg->transfers, transfer_list) {
> @@ -296,7 +296,7 @@ static int bcm63xx_hsspi_transfer_one(struct
> spi_master *master,
> spi_transfer_delay_exec(t);
>
> if (t->cs_change)
> - bcm63xx_hsspi_set_cs(bs, spi->chip_select, false);
> + bcm63xx_hsspi_set_cs(bs, spi_get_chipselect(spi, 0), false);
> }
>
> mutex_lock(&bs->bus_mutex);
For bcm63xx-hsspi driver,
Acked-by: William Zhang <william.zhang@broadcom•com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
next prev parent reply other threads:[~2023-01-25 0:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 18:53 [PATCH v2 00/13] spi: Add support for stacked/parallel memories Amit Kumar Mahapatra
2023-01-19 18:53 ` [PATCH v2 01/13] spi: Add APIs in spi core to set/get spi->chip_select and spi->cs_gpiod Amit Kumar Mahapatra
2023-01-23 12:44 ` Michal Simek
2023-01-19 18:53 ` [PATCH v2 02/13] spi: Replace all spi->chip_select and spi->cs_gpiod references with function call Amit Kumar Mahapatra
2023-01-20 9:47 ` Heiko Stübner
2023-01-23 12:46 ` Michal Simek
2023-01-23 13:10 ` Cédric Le Goater
2023-01-23 14:20 ` Dhruva Gole
2023-01-23 15:04 ` Serge Semin
2023-01-23 17:16 ` Patrice CHOTARD
2023-01-25 0:57 ` William Zhang [this message]
2023-02-01 15:15 ` Mark Brown
2023-01-19 18:53 ` [PATCH v2 03/13] net: " Amit Kumar Mahapatra
2023-01-20 10:30 ` Lukasz Stelmach
2023-01-23 12:46 ` Michal Simek
2023-01-19 18:53 ` [PATCH v2 04/13] iio: imu: " Amit Kumar Mahapatra
2023-01-21 16:52 ` Jonathan Cameron
2023-01-23 12:47 ` Michal Simek
2023-01-19 18:53 ` [PATCH v2 05/13] mtd: devices: " Amit Kumar Mahapatra
2023-01-23 12:47 ` Michal Simek
2023-01-19 18:53 ` [PATCH v2 06/13] staging: " Amit Kumar Mahapatra
2023-01-20 10:09 ` Greg KH
2023-01-23 12:47 ` Michal Simek
2023-01-19 18:53 ` [PATCH v2 07/13] platform/x86: serial-multi-instantiate: " Amit Kumar Mahapatra
2023-01-23 12:48 ` Michal Simek
2023-01-19 18:53 ` [PATCH v2 08/13] spi: Add stacked and parallel memories support in SPI core Amit Kumar Mahapatra
2023-01-19 18:53 ` [PATCH v2 09/13] mtd: spi-nor: Add APIs to set/get nor->params Amit Kumar Mahapatra
2023-01-19 18:53 ` [PATCH v2 10/13] mtd: spi-nor: Add stacked memories support in spi-nor Amit Kumar Mahapatra
2023-01-23 12:40 ` Michal Simek
2023-01-19 18:53 ` [PATCH v2 11/13] spi: spi-zynqmp-gqspi: Add stacked memories support in GQSPI driver Amit Kumar Mahapatra
2023-01-19 18:53 ` [PATCH v2 12/13] mtd: spi-nor: Add parallel memories support in spi-nor Amit Kumar Mahapatra
2023-01-19 18:53 ` [PATCH v2 13/13] spi: spi-zynqmp-gqspi: Add parallel memories support in GQSPI driver Amit Kumar Mahapatra
2023-02-01 16:57 ` (subset) [PATCH v2 00/13] spi: Add support for stacked/parallel memories Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36840e0caeca5f53eef4fab615fc7976@mail.gmail.com \
--to=william.zhang@broadcom$(echo .)com \
--cc=Michael.Hennerich@analog$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=alex.aring@gmail$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=alim.akhtar@samsung$(echo .)com \
--cc=amit.kumar-mahapatra@amd$(echo .)com \
--cc=amitrkcian2002@gmail$(echo .)com \
--cc=andi@etezian$(echo .)org \
--cc=andrew@aj$(echo .)id.au \
--cc=avifishman70@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=benjaminfair@google$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=chin-ting_kuo@aspeedtech$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=claudiu.beznea@microchip$(echo .)com \
--cc=clg@kaod$(echo .)org \
--cc=daniel@zonque$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=eajames@linux$(echo .)ibm.com \
--cc=edumazet@google$(echo .)com \
--cc=elder@kernel$(echo .)org \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fancer.lancer@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=git@amd$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=greybus-dev@lists$(echo .)linaro.org \
--cc=haibo.chen@nxp$(echo .)com \
--cc=han.xu@nxp$(echo .)com \
--cc=haojian.zhuang@gmail$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=j.neuschaefer@gmx$(echo .)net \
--cc=jaswinder.singh@linaro$(echo .)org \
--cc=jbrunet@baylibre$(echo .)com \
--cc=jernej.skrabec@gmail$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=joel@jms$(echo .)id.au \
--cc=johan@kernel$(echo .)org \
--cc=john.garry@huawei$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kdasu.kdev@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=khilman@baylibre$(echo .)com \
--cc=konrad.dybcio@somainline$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=l.stelmach@samsung$(echo .)com \
--cc=lars@metafoo$(echo .)de \
--cc=ldewangan@nvidia$(echo .)com \
--cc=libertas-dev@lists$(echo .)infradead.org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-sunxi@lists$(echo .)linux.dev \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux-wpan@vger$(echo .)kernel.org \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=masahisa.kojima@linaro$(echo .)org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=michael@walle$(echo .)cc \
--cc=michal.simek@amd$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.ferre@microchip$(echo .)com \
--cc=olteanv@gmail$(echo .)com \
--cc=openbmc@lists$(echo .)ozlabs.org \
--cc=pabeni@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=pratyush@kernel$(echo .)org \
--cc=radu_nicolae.pirea@upb$(echo .)ro \
--cc=richard@nod$(echo .)at \
--cc=rjui@broadcom$(echo .)com \
--cc=rmfrfs@gmail$(echo .)com \
--cc=robert.jarzmik@free$(echo .)fr \
--cc=rostedt@goodmis$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=samuel@sholland$(echo .)org \
--cc=sanju.mehta@amd$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=skomatineni@nvidia$(echo .)com \
--cc=stefan@datenfreihafen$(echo .)org \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=tali.perry1@gmail$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tmaimon77@gmail$(echo .)com \
--cc=tudor.ambarus@microchip$(echo .)com \
--cc=venture@google$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=vireshk@kernel$(echo .)org \
--cc=wens@csie$(echo .)org \
--cc=yogeshgaur.83@gmail$(echo .)com \
--cc=yuenn@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox