Subject: Re: [PATCH] sunrpc: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email-masked]>
Date: Mon, 26 Feb 2024 12:23:49 +0800

On 2024/2/24 21:51, [email-masked] wrote:
> From: Chengming Zhou <[email-masked]>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/[email-masked]/

Thanks!

> 
> Signed-off-by: Chengming Zhou <[email-masked]>
> ---
>  net/sunrpc/rpc_pipe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c
> index dcc2b4f49e77..910a5d850d04 100644
> --- a/net/sunrpc/rpc_pipe.c
> +++ b/net/sunrpc/rpc_pipe.c
> @@ -1490,7 +1490,7 @@ int register_rpc_pipefs(void)
>  	rpc_inode_cachep = kmem_cache_create("rpc_inode_cache",
>  				sizeof(struct rpc_inode),
>  				0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
> -						SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> +						SLAB_ACCOUNT),
>  				init_once);
>  	if (!rpc_inode_cachep)
>  		return -ENOMEM;