Subject: Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

From: Oliver Neukum <[email-masked]>
Date: Fri, 12 Apr 2013 09:28:59 +0200

On Thursday 11 April 2013 10:28:33 Dan Williams wrote:
> > Looks it isn't a good practice to duplicate code in above four functions, but
> > it should be OK to merge first.
> 
> Oliver requested this approach.  I'd originally taken your suggestion to
> merge them, but this proved somewhat more complicated and Oliver
> rejected that approach.

We don't do functions which do a different thing based on flags.
Linus chewed our posteriors for that.

	Regards
		Oliver