From: Jeff Garzik <jgarzik@pobox•com>
To: netdev@oss•sgi.com
Cc: davem@redhat•com, kuznet@ms2•inr.ac.ru
Subject: qdisc_restart locking bug?
Date: Fri, 15 Nov 2002 14:01:22 -0500 [thread overview]
Message-ID: <3DD54482.802@pobox.com> (raw)
When qdisc_restart() is called from qdisc_run(), dev->queue_lock is
obtained via spin_lock_bh().
When dev->hard_start_xmit() is called from qdisc_restart(),
dev->queue_lock is dropped, and then re-acquired using only spin_lock().
So, doesn't qdisc_restart need s/spin_lock/spin_lock_bh/ for
dev->queue_lock?
When looking at the dev_queue_xmit -> qdisc_run -> qdisc_restart call
path, it seems so to me.
Jeff
next reply other threads:[~2002-11-15 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-15 19:01 Jeff Garzik [this message]
2002-11-15 21:41 ` qdisc_restart locking bug? kuznet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DD54482.802@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=davem@redhat$(echo .)com \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@oss$(echo .)sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox