From: Jeff Garzik <jgarzik@pobox•com>
To: Stephen Hemminger <shemminger@osdl•org>
Cc: netdev@oss•sgi.com
Subject: Re: [PATCH] convert wan/lmc to device model
Date: Sat, 20 Sep 2003 13:47:31 -0400 [thread overview]
Message-ID: <3F6C92B3.3060603@pobox.com> (raw)
In-Reply-To: <20030916143627.51a08be0.shemminger@osdl.org>
Stephen Hemminger wrote:
> This patch converts drivers/net/wan/lmc for 2.6.0-test5
> - use pci_device model
> - get rid of MOD_INC/DEC
> - use alloc_netdev and dev->priv for private data
>
> Builds and loads but don't have real hardware.
>
> diff -Nru a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
> --- a/drivers/net/wan/lmc/lmc_main.c Tue Sep 16 14:33:16 2003
> +++ b/drivers/net/wan/lmc/lmc_main.c Tue Sep 16 14:33:16 2003
> @@ -78,30 +78,20 @@
> #include "lmc_debug.h"
> #include "lmc_proto.h"
>
> -
> -static int Lmc_Count = 0;
> -static struct net_device *Lmc_root_dev = NULL;
> -static u8 cards_found = 0;
> -
> static int lmc_first_load = 0;
>
> -int LMC_PKT_BUF_SZ = 1542;
> +static int LMC_PKT_BUF_SZ = 1542;
>
> -#ifdef MODULE
> static struct pci_device_id lmc_pci_tbl[] = {
> - { 0x1011, 0x009, 0x1379, PCI_ANY_ID, 0, 0, 0},
> - { 0, }
> + { CORRECT_VENDOR_ID, CORRECT_DEV_ID, PCI_VENDOR_LMC, PCI_ANY_ID },
> + { CORRECT_VENDOR_ID, CORRECT_DEV_ID, PCI_ANY_ID, PCI_VENDOR_LMC },
> + { 0 }
Um, this is majorly ugly. I know you didn't create the CORRECT_xxx
constants... but let's not use them. Either use the hex constants
directly, or update pci_ids.h and use the constants from there.
Jeff
next prev parent reply other threads:[~2003-09-20 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-16 21:36 [PATCH] convert wan/lmc to device model Stephen Hemminger
2003-09-20 17:47 ` Jeff Garzik [this message]
2003-09-22 18:46 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F6C92B3.3060603@pobox.com \
--to=jgarzik@pobox$(echo .)com \
--cc=netdev@oss$(echo .)sgi.com \
--cc=shemminger@osdl$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox