Subject: Re: [PATCH v10 05/26] cxl: add function for type2 cxl regs setup

From: Alejandro Lucero Palau <[email-masked]>
Date: Thu, 6 Feb 2025 17:50:47 +0000

On 2/5/25 21:35, Ira Weiny wrote:
> alucerop@ wrote:
>> From: Alejandro Lucero <[email-masked]>
> [snip]
>
>> +
>> +int cxl_pci_accel_setup_regs(struct pci_dev *pdev, struct cxl_memdev_state *cxlmds,
>> +			      unsigned long *caps)
>> +{
>> +	struct cxl_dev_state *cxlds = &cxlmds->cxlds;
> Isn't it odd that cxl_memdev_state is passed here only to be turned into
> what you really need, cxl_dev_state?
>
> Ira
>
>
> [snip]

Yes. The only explanation is to keep calls in the accel API orthogonal 
always using cxl_memdev_state now.

The interesting part comes later in other of your reviews.