From: Tianyu Lan <ltykernel@gmail•com>
To: Dave Hansen <dave.hansen@intel•com>,
kys@microsoft•com, haiyangz@microsoft•com,
sthemmin@microsoft•com, wei.liu@kernel•org, decui@microsoft•com,
tglx@linutronix•de, mingo@redhat•com, bp@alien8•de,
x86@kernel•org, hpa@zytor•com, dave.hansen@linux•intel.com,
luto@kernel•org, peterz@infradead•org, konrad.wilk@oracle•com,
boris.ostrovsky@oracle•com, jgross@suse•com,
sstabellini@kernel•org, joro@8bytes•org, will@kernel•org,
davem@davemloft•net, kuba@kernel•org, jejb@linux•ibm.com,
martin.petersen@oracle•com, arnd@arndb•de, hch@lst•de,
m.szyprowski@samsung•com, robin.murphy@arm•com,
thomas.lendacky@amd•com, brijesh.singh@amd•com, ardb@kernel•org,
Tianyu.Lan@microsoft•com, pgonda@google•com,
martin.b.radev@gmail•com, akpm@linux-foundation•org,
kirill.shutemov@linux•intel.com, rppt@kernel•org,
sfr@canb•auug.org.au, saravanand@fb•com,
krish.sadhukhan@oracle•com, aneesh.kumar@linux•ibm.com,
xen-devel@lists•xenproject.org, rientjes@google•com,
hannes@cmpxchg•org, tj@kernel•org,
michael.h.kelley@microsoft•com
Cc: iommu@lists•linux-foundation.org, linux-arch@vger•kernel.org,
linux-hyperv@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-scsi@vger•kernel.org, netdev@vger•kernel.org,
vkuznets@redhat•com, parri.andrea@gmail•com
Subject: Re: [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support
Date: Tue, 10 Aug 2021 21:09:16 +0800 [thread overview]
Message-ID: <3f09c505-3e4d-3b06-e92a-db6fd3e50d0c@gmail.com> (raw)
In-Reply-To: <a0499916-38e2-0b1e-f2b9-ef760f6d4d92@intel.com>
On 8/10/2021 6:12 AM, Dave Hansen wrote:
> On 8/9/21 10:56 AM, Tianyu Lan wrote:
>> From: Tianyu Lan <Tianyu.Lan@microsoft•com>
>>
>> Add new hvcall guest address host visibility support to mark
>> memory visible to host. Call it inside set_memory_decrypted
>> /encrypted(). Add HYPERVISOR feature check in the
>> hv_is_isolation_supported() to optimize in non-virtualization
>> environment.
>
> From an x86/mm perspective:
>
> Acked-by: Dave Hansen <dave.hansen@intel•com>
>
Thanks for your ACK.
> A tiny nit:
>
>> diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
>> index 0bb4d9ca7a55..b3683083208a 100644
>> --- a/arch/x86/hyperv/hv_init.c
>> +++ b/arch/x86/hyperv/hv_init.c
>> @@ -607,6 +607,12 @@ EXPORT_SYMBOL_GPL(hv_get_isolation_type);
>>
>> bool hv_is_isolation_supported(void)
>> {
>> + if (!cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
>> + return 0;
>> +
>> + if (!hypervisor_is_type(X86_HYPER_MS_HYPERV))
>> + return 0;
>> +
>> return hv_get_isolation_type() != HV_ISOLATION_TYPE_NONE;
>> }
> This might be worthwhile to move to a header. That ensures that
> hv_is_isolation_supported() use can avoid even a function call. But, I
> see this is used in modules and its use here is also in a slow path, so
> it's not a big deal
>
I will move it to header in the following version.
Thanks.
next prev parent reply other threads:[~2021-08-10 13:09 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 17:56 [PATCH V3 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 01/13] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan
2021-08-10 10:56 ` Wei Liu
2021-08-10 12:17 ` Tianyu Lan
2021-08-12 19:14 ` Michael Kelley
2021-08-13 15:46 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 02/13] x86/HV: Initialize shared memory boundary in the " Tianyu Lan
2021-08-12 19:18 ` Michael Kelley
2021-08-14 13:32 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 03/13] x86/HV: Add new hvcall guest address host visibility support Tianyu Lan
2021-08-09 22:12 ` Dave Hansen
2021-08-10 13:09 ` Tianyu Lan [this message]
2021-08-10 11:03 ` Wei Liu
2021-08-10 12:25 ` Tianyu Lan
2021-08-12 19:36 ` Michael Kelley
2021-08-12 21:10 ` Michael Kelley
2021-08-09 17:56 ` [PATCH V3 04/13] HV: Mark vmbus ring buffer visible to host in Isolation VM Tianyu Lan
2021-08-12 22:20 ` Michael Kelley
2021-08-15 15:21 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 05/13] HV: Add Write/Read MSR registers via ghcb page Tianyu Lan
2021-08-13 19:31 ` Michael Kelley
2021-08-13 20:26 ` Michael Kelley
2021-08-24 8:45 ` Christoph Hellwig
2021-08-09 17:56 ` [PATCH V3 06/13] HV: Add ghcb hvcall support for SNP VM Tianyu Lan
2021-08-13 20:42 ` Michael Kelley
2021-08-09 17:56 ` [PATCH V3 07/13] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan
2021-08-13 21:28 ` Michael Kelley
2021-08-09 17:56 ` [PATCH V3 08/13] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan
2021-08-16 17:28 ` Michael Kelley
2021-08-17 15:36 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 09/13] DMA: Add dma_map_decrypted/dma_unmap_encrypted() function Tianyu Lan
2021-08-12 12:26 ` Christoph Hellwig
2021-08-12 15:38 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 10/13] x86/Swiotlb: Add Swiotlb bounce buffer remap function for HV IVM Tianyu Lan
2021-08-12 12:27 ` Christoph Hellwig
2021-08-13 17:58 ` Tianyu Lan
2021-08-16 14:50 ` Tianyu Lan
2021-08-19 8:49 ` Christoph Hellwig
2021-08-19 9:59 ` Tianyu Lan
2021-08-19 10:02 ` Christoph Hellwig
2021-08-19 10:03 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 11/13] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan
2021-08-19 18:11 ` Michael Kelley
2021-08-20 4:13 ` hch
2021-08-20 9:32 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 12/13] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan
2021-08-19 18:14 ` Michael Kelley
2021-08-20 4:21 ` hch
2021-08-20 13:11 ` Tianyu Lan
2021-08-20 13:30 ` Tom Lendacky
2021-08-20 18:20 ` Tianyu Lan
2021-08-09 17:56 ` [PATCH V3 13/13] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan
2021-08-19 18:17 ` Michael Kelley
2021-08-20 4:32 ` hch
2021-08-20 15:40 ` Michael Kelley
2021-08-24 8:49 ` min_align_mask " hch
2021-08-20 16:01 ` Tianyu Lan
2021-08-20 15:20 ` Tianyu Lan
2021-08-20 15:37 ` Tianyu Lan
2021-08-20 16:08 ` Michael Kelley
2021-08-20 18:04 ` Tianyu Lan
2021-08-20 19:22 ` Michael Kelley
2021-08-24 8:46 ` hch
2021-08-16 14:55 ` [PATCH V3 00/13] x86/Hyper-V: Add Hyper-V Isolation VM support Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f09c505-3e4d-3b06-e92a-db6fd3e50d0c@gmail.com \
--to=ltykernel@gmail$(echo .)com \
--cc=Tianyu.Lan@microsoft$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=boris.ostrovsky@oracle$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brijesh.singh@amd$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hannes@cmpxchg$(echo .)org \
--cc=hch@lst$(echo .)de \
--cc=hpa@zytor$(echo .)com \
--cc=iommu@lists$(echo .)linux-foundation.org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jgross@suse$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=konrad.wilk@oracle$(echo .)com \
--cc=krish.sadhukhan@oracle$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kys@microsoft$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=luto@kernel$(echo .)org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=martin.b.radev@gmail$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=michael.h.kelley@microsoft$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=parri.andrea@gmail$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=pgonda@google$(echo .)com \
--cc=rientjes@google$(echo .)com \
--cc=robin.murphy@arm$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=saravanand@fb$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sstabellini@kernel$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=tj@kernel$(echo .)org \
--cc=vkuznets@redhat$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox