From: Robin Murphy <robin.murphy@arm•com>
To: Simon Horman <simon.horman@corigine•com>
Cc: kuba@kernel•org, davem@davemloft•net, oss-drivers@corigine•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next] nfp: nsp: Simplify array allocation
Date: Thu, 27 Jan 2022 12:42:31 +0000 [thread overview]
Message-ID: <3f6df255-0a04-e630-e8cb-8407a704acb3@arm.com> (raw)
In-Reply-To: <20220127090636.GA21279@corigine.com>
On 2022-01-27 09:06, Simon Horman wrote:
> On Wed, Jan 26, 2022 at 04:30:33PM +0000, Robin Murphy wrote:
>> Prefer kcalloc() to kzalloc(array_size()) for allocating an array.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm•com>
>
> Hi Robin,
>
> thanks for the cleanup.
>
> One minor nit: I think "nfp: " would be a slightly more normal prefix
> than "nfp: nsp: ".
Ah, OK - from the git history it seemed about 50/50 one way or the
other, so I guessed at the one that looked more specific to this
particular file. I ran into this little anti-pattern in code I was
working on, and this was the only other instance that a quick grep
turned up so I figured I may as well fix it too.
> That notwithstanding,
>
> Acked-by: Simon Horman <simon.horman@corigine•com>
Thanks!
Robin.
>> ---
>> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c
>> index 10e7d8b21c46..730fea214b8a 100644
>> --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c
>> +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c
>> @@ -513,7 +513,7 @@ nfp_nsp_command_buf_dma_sg(struct nfp_nsp *nsp,
>> dma_size = BIT_ULL(dma_order);
>> nseg = DIV_ROUND_UP(max_size, chunk_size);
>>
>> - chunks = kzalloc(array_size(sizeof(*chunks), nseg), GFP_KERNEL);
>> + chunks = kcalloc(nseg, sizeof(*chunks), GFP_KERNEL);
>> if (!chunks)
>> return -ENOMEM;
>>
>> --
>> 2.28.0.dirty
>>
next prev parent reply other threads:[~2022-01-27 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 16:30 [PATCH net-next] nfp: nsp: Simplify array allocation Robin Murphy
2022-01-27 9:06 ` Simon Horman
2022-01-27 12:42 ` Robin Murphy [this message]
2022-01-27 14:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f6df255-0a04-e630-e8cb-8407a704acb3@arm.com \
--to=robin.murphy@arm$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox