From: Eric Dumazet <eric.dumazet@gmail•com>
To: fankaixi.li@bytedance•com, dev@openvswitch•org, netdev@vger•kernel.org
Cc: xiexiaohui <xiexiaohui.xxh@bytedance•com>,
Cong Wang <cong.wang@bytedance•com>
Subject: Re: [PATCH] ovs: clear skb->tstamp in forwarding path
Date: Wed, 18 Aug 2021 11:32:03 +0200 [thread overview]
Message-ID: <401464ef-2238-ebe0-c661-714403083317@gmail.com> (raw)
In-Reply-To: <20210818022215.5979-1-fankaixi.li@bytedance.com>
On 8/18/21 4:22 AM, fankaixi.li@bytedance•com wrote:
> From: kaixi.fan <fankaixi.li@bytedance•com>
>
> fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
> doesn't clear skb->tstamp. We encountered a problem with linux
> version 5.4.56 and ovs version 2.14.1, and packets failed to
> dequeue from qdisc when fq qdisc was attached to ovs port.
>
Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
This is more precise than " version 5.4.56 and ovs version ..."
Thanks.
> Signed-off-by: kaixi.fan <fankaixi.li@bytedance•com>
> Signed-off-by: xiexiaohui <xiexiaohui.xxh@bytedance•com>
> Reviewed-by: Cong Wang <cong.wang@bytedance•com>
> ---
> net/openvswitch/vport.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> index 88deb5b41429..cf2ce5812489 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
> }
>
> skb->dev = vport->dev;
> + skb->tstamp = 0;
> vport->ops->send(skb);
> return;
>
>
next prev parent reply other threads:[~2021-08-18 9:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 2:22 [PATCH] ovs: clear skb->tstamp in forwarding path fankaixi.li
2021-08-18 9:32 ` Eric Dumazet [this message]
2021-08-19 2:06 ` [External] " 范开喜
2021-08-18 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401464ef-2238-ebe0-c661-714403083317@gmail.com \
--to=eric.dumazet@gmail$(echo .)com \
--cc=cong.wang@bytedance$(echo .)com \
--cc=dev@openvswitch$(echo .)org \
--cc=fankaixi.li@bytedance$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiexiaohui.xxh@bytedance$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox