From: Arnd Bergmann <arnd@arndb•de>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: [PATCH] net: mv643xx_eth: add missing semicolon
Date: Mon, 03 Jun 2013 15:11:24 +0200 [thread overview]
Message-ID: <4063428.ukZe9BdPSb@wuerfel> (raw)
76723bca28 "net: mv643xx_eth: add DT parsing support" added a
dummy mv643xx_eth_shared_of_probe() fallback function with a
typo.
This adds the missing semicolon so we can build without CONFIG_OF
again, and changes both dummy functions to the more conventional
"static inline" syntax, which can avoid potential problems with
the empty macro.
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index 23ea7b6..c7f9fb3 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2582,12 +2582,14 @@ static void mv643xx_eth_shared_of_remove(void)
}
}
#else
-static int mv643xx_eth_shared_of_probe(struct platform_device *pdev)
+static inline int mv643xx_eth_shared_of_probe(struct platform_device *pdev)
{
- return 0
+ return 0;
}
-#define mv643xx_eth_shared_of_remove()
+static inline void mv643xx_eth_shared_of_remove(void)
+{
+}
#endif
static int mv643xx_eth_shared_probe(struct platform_device *pdev)
next reply other threads:[~2013-06-03 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 13:11 Arnd Bergmann [this message]
2013-06-04 6:35 ` [PATCH] net: mv643xx_eth: add missing semicolon Sebastian Hesselbarth
2013-06-05 0:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4063428.ukZe9BdPSb@wuerfel \
--to=arnd@arndb$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox