public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Nivedita Singhvi <niv@us•ibm.com>
To: David Stevens <dlstevens@us•ibm.com>
Cc: Patrick McHardy <kaber@trash•net>,
	"David S. Miller" <davem@redhat•com>,
	laforge@netfilter•org, netdev@oss•sgi.com,
	netdev-bounce@oss•sgi.com, netfilter-devel@lists•netfilter.org,
	okir@suse•de
Subject: Re: [PATCH] Prevent crash on ip_conntrack removal
Date: Mon, 23 Aug 2004 17:45:20 -0700	[thread overview]
Message-ID: <412A8FA0.1010707@us.ibm.com> (raw)
In-Reply-To: <OF4320C747.75C5E93A-ON88256EF9.00744FBA-88256EF9.00750996@us.ibm.com>

David Stevens wrote:

> So, one solution would be to set skb->dst for the head (if NULL)  based
> on a non-null fragment skb->dst. I believe that would prevent the problem
> case without dropping the fragment, since it'll be processed post-routing
> only if one of the frags is.

This would be more performant than dropping the frags, and
requiring a retransmit (or lack thereof, depending on protocol).

> When I was looking at it, I wondered if conntrack really has a need to
> reassemble itself, though. Couldn't it let IP do the reassembling and

I asked Harald this when I met him last, and he said it
does need to. So I don't think this (having conntrack
reassemble) is avoidable, unfortunately.

Of course, fragmentation, on the other hand, :), ...

thanks,
Nivedita

next prev parent reply	other threads:[~2004-08-24  0:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-18  9:13 [PATCH] Prevent crash on ip_conntrack removal Olaf Kirch
2004-08-19 10:11 ` Harald Welte
2004-08-19 14:18   ` David S. Miller
2004-08-19 14:55     ` Patrick McHardy
2004-08-19 15:14       ` David S. Miller
2004-08-21 15:10         ` Patrick McHardy
2004-08-22  5:13           ` David S. Miller
2004-08-22 12:58             ` Patrick McHardy
2004-08-23  5:03               ` David S. Miller
2004-08-23 21:18               ` David Stevens
2004-08-24  0:45                 ` Nivedita Singhvi [this message]
2004-08-24  0:45                 ` Patrick McHardy
2004-08-24 21:28                   ` David Stevens
2004-08-29  6:15                     ` David S. Miller
2004-08-29 19:36                       ` Patrick McHardy
2004-08-29 19:57                         ` David S. Miller
2004-08-29 20:06                           ` Patrick McHardy
2004-08-29 21:58                           ` Patrick McHardy
2004-08-29 23:38                             ` David S. Miller
2004-08-30  0:50                               ` Patrick McHardy
2004-08-30  4:28                                 ` David S. Miller
2004-08-29 21:48                         ` Patrick McHardy
2004-08-30  7:57                         ` Olaf Kirch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=412A8FA0.1010707@us.ibm.com \
    --to=niv@us$(echo .)ibm.com \
    --cc=davem@redhat$(echo .)com \
    --cc=dlstevens@us$(echo .)ibm.com \
    --cc=kaber@trash$(echo .)net \
    --cc=laforge@netfilter$(echo .)org \
    --cc=netdev-bounce@oss$(echo .)sgi.com \
    --cc=netdev@oss$(echo .)sgi.com \
    --cc=netfilter-devel@lists$(echo .)netfilter.org \
    --cc=okir@suse$(echo .)de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox