Subject: Re: [PATCH] introduce eth_hdr(skb)

From: Arnaldo Carvalho de Melo <[email-masked]>
Date: Sat, 02 Oct 2004 14:22:41 -0300

Joe Perches wrote:
> 
> -       } else if (skb->mac.ethernet->h_proto == __constant_htons(ETH_P_ARP)) {
> +       } else if (eth_hdr(skb)->h_proto == htons(ETH_P_ARP)) {
> 
> I believe the __constant_htons conversions to htons are incorrect.

No they aren't, look at the generated code for both variations when 
receiving a constant :-)

- Arnaldo