From: Arnaldo Carvalho de Melo <acme@conectiva•com.br>
To: Thomas Graf <tgraf@suug•ch>
Cc: "David S. Miller" <davem@redhat•com>, netdev@oss•sgi.com
Subject: Re: PATCH: [SKBUFF] introduce skb_link_header_size(skb)
Date: Tue, 05 Oct 2004 16:45:33 -0300 [thread overview]
Message-ID: <4162F9DD.2070705@conectiva.com.br> (raw)
In-Reply-To: <20041005193352.GA19714@rei.reeler.org>
Thomas Graf wrote:
> * Arnaldo Carvalho de Melo <4162F28B.2050308@conectiva•com.br> 2004-10-05 16:14
>
>>+static inline int skb_link_header_size(const struct sk_buff *skb)
>>+{
>>+ return skb->nh.raw - skb->mac.raw;
>>+}
>
>
> The patch is valid and I think it is right to do so but this may lead to
> wrong results when skb->mac.raw is set to 0x0 F.e in classifiers. Maybe
> add a comment to warn about it?
I never looked at classifiers code, suggest a comment and I'll stick it
there.
Thanks for commenting on the patch.
Regards,
- Arnaldo
prev parent reply other threads:[~2004-10-05 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 19:14 PATCH: [SKBUFF] introduce skb_link_header_size(skb) Arnaldo Carvalho de Melo
2004-10-05 19:33 ` Thomas Graf
2004-10-05 19:45 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4162F9DD.2070705@conectiva.com.br \
--to=acme@conectiva$(echo .)com.br \
--cc=davem@redhat$(echo .)com \
--cc=netdev@oss$(echo .)sgi.com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox