Subject: Re: [PATCH] Change masquerade code to use first IP address of interface.

From: Patrick McHardy <[email-masked]>
Date: Wed, 20 Oct 2004 19:42:15 +0200

Herbert Xu wrote:

>Rusty Russell <[email-masked]> wrote:
>  
>
>>+       newsrc = inet_select_addr(out, 0, RT_SCOPE_UNIVERSE);
>>+       if (!newsrc) {
>>+               printk("MASQUERADE: %s ate my IP address\n", out->name);
>>+               return NF_DROP;
>>    
>>
>
>Wouldn't it be better to select the address for the gateway that we're
>sending towards?
>  
>

I agree. Rusty, I already have your patch queued in a
post-2.6.9 tree, I'm going to add Herbert's patch on top.

Regards
Patrick