From: Ross Kendall Axe <ross.axe@blueyonder•co.uk>
To: Chris Wright <chrisw@osdl•org>
Cc: James Morris <jmorris@redhat•com>,
netdev@oss•sgi.com, Stephen Smalley <sds@epoch•ncsc.mil>,
lkml <linux-kernel@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET
Date: Fri, 19 Nov 2004 03:23:50 +0000 [thread overview]
Message-ID: <419D6746.2020603@blueyonder.co.uk> (raw)
In-Reply-To: <20041118084449.Z14339@build.pdx.osdl.net>
[-- Attachment #1: Type: text/plain, Size: 1547 bytes --]
Chris Wright wrote:
>
> Why not make a unix_seq_sendmsg, which is a very small wrapper?
> e.g.
> static int unix_seq_sendmsg(struct kiocb *kiocb, struct socket *sock,
> struct msghdr *msg, size_t len)
> {
> struct sock *sk = sock->sk;
>
> if (sk->sk_type == SOCK_SEQPACKET && sk->sk_state != TCP_ESTABLISHED)
> return -ENOTCONN;
> if (msg->msg_name || msg->msg_namelen)
> return -EINVAL;
> return unix_dgram_sendmsg(kiocb, sock, msg, len);
> }
>
>
> -chris
Taking this idea further, couldn't we split unix_dgram_sendmsg into 2
functions, do_unix_dgram_sendmsg and do_unix_connectionless_sendmsg (and
similarly for unix_stream_sendmsg), then all we'd need is:
<pseudocode>
static int do_unix_dgram_sendmsg(...);
static int do_unix_stream_sendmsg(...);
static int do_unix_connectionless_sendmsg(...);
static int do_unix_connectional_sendmsg(...);
static int unix_dgram_sendmsg(struct kiocb *kiocb, struct socket *sock,
struct msghdr *msg, size_t len)
{
return do_unix_connectionless_sendmsg(kiocb, sock, msg, len,
do_unix_dgram_sendmsg);
}
static int unix_stream_sendmsg(struct kiocb *kiocb, struct socket *sock,
struct msghdr *msg, size_t len)
{
return do_unix_connectional_sendmsg(kiocb, sock, msg, len,
do_unix_stream_sendmsg);
}
static int unix_seqpacket_sendmsg(struct kiocb *kiocb, struct socket *sock,
struct msghdr *msg, size_t len)
{
return do_unix_connectional_sendmsg(kiocb, sock, msg, len,
do_unix_dgram_sendmsg);
}
</pseudocode>
What do we think?
Ross
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
next prev parent reply other threads:[~2004-11-19 3:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-14 18:13 [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET Ross Kendall Axe
2004-11-15 13:31 ` Stephen Smalley
2004-11-16 8:41 ` Chris Wright
2004-11-17 21:29 ` Ross Kendall Axe
2004-11-18 0:09 ` Ross Kendall Axe
2004-11-18 3:42 ` James Morris
2004-11-18 4:25 ` James Morris
2004-11-18 6:07 ` Chris Wright
2004-11-18 7:25 ` Ross Kendall Axe
2004-11-18 7:59 ` James Morris
2004-11-18 8:27 ` James Morris
2004-11-18 16:44 ` Chris Wright
2004-11-18 17:01 ` James Morris
2004-11-18 17:07 ` Chris Wright
2004-11-18 17:11 ` James Morris
2004-11-18 17:25 ` James Morris
2004-11-18 16:58 ` Alan Cox
2004-11-18 22:34 ` David S. Miller
2004-11-19 3:23 ` Ross Kendall Axe [this message]
2004-11-19 7:19 ` Chris Wright
2004-11-19 9:40 ` Ross Kendall Axe
2004-11-19 13:05 ` Arnaldo Carvalho de Melo
2004-11-19 13:16 ` Arnaldo Carvalho de Melo
2004-11-18 16:49 ` Alan Cox
2004-11-18 18:40 ` James Morris
2004-11-18 23:39 ` Alan Cox
2004-11-19 3:12 ` James Morris
2004-11-19 7:01 ` Chris Wright
2004-11-19 7:12 ` James Morris
2004-11-19 7:28 ` Chris Wright
2004-11-19 11:39 ` Alan Cox
2004-11-19 16:24 ` James Morris
2004-11-20 7:11 ` David S. Miller
2004-11-18 16:45 ` Alan Cox
2004-11-18 18:28 ` James Morris
2004-11-18 18:34 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=419D6746.2020603@blueyonder.co.uk \
--to=ross.axe@blueyonder$(echo .)co.uk \
--cc=chrisw@osdl$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@redhat$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@oss$(echo .)sgi.com \
--cc=sds@epoch$(echo .)ncsc.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox