Subject: Re: [patch 10/13] net/socket.c::sys_bind() cleanup.

From: Luiz Fernando Capitulino <[email-masked]>
Date: Wed, 24 Nov 2004 08:55:10 -0200

David S. Miller wrote:
> On Sun, 21 Nov 2004 22:43:56 -0800
> [email-masked] wrote:
> 
> 
>>From: "Luiz Fernando N. Capitulino" <[email-masked]>
>>
>>net/socket.c::sys_bind() is a bit complex function, the patch below makes
>>it more clear.
>>
>>Signed-off-by: Luiz Capitulino <[email-masked]>
>>Signed-off-by: Andrew Morton <[email-masked]>
> 
> 
> This was commented on to be buggy, or at least change behavior.
> The "if (err >= 0)" tests were changed to flat "if (err)" tests.

  It doesn't a buggy or change behaivor.

  What happens here is that move_addr_to_kernel() returns 0
success and -EINVAL or -EFAULT on error. Thus, change from
"if (err >= 0)" to "if (err)" is safe.

  Also, it was discussed and ACK'ed by James Morris:

http://lkml.org/lkml/2004/11/16/339

  The real problem here I've made a bad patch
description. I'll try to make it better next time.

  thanks,

-- 
Luiz Fernando N. Capitulino