Subject: Re: [PATCH 1/5] sis900 printk and stack usage audit

From: Jeff Garzik <[email-masked]>
Date: Sat, 11 Dec 2004 14:06:21 -0500

Daniele Venzano wrote:
> Removed double printing of version string in module_init and in sis900_probe

> @@ -390,13 +390,6 @@
>  	u8 revision;
>  	char *card_name = card_names[pci_id->driver_data];
>  
> -/* when built into the kernel, we only print version if device is found */
> -#ifndef MODULE
> -	static int printed_version;
> -	if (!printed_version++)
> -		printk(version);
> -#endif
> -
>  	/* setup various bits in PCI command register */
>  	ret = pci_enable_device(pci_dev);
>  	if(ret) return ret;

There is no double-printing.  One is #ifndef MODULE, one is #ifdef MODULE.

Did you read the comment included in the code you deleted???

	Jeff