Subject: Re: [RFC] tulip VLAN support

From: Ben Greear <[email-masked]>
Date: Wed, 05 Jan 2005 14:17:57 -0800

Jeff Garzik wrote:
> Johannes Erdfelt wrote:
> 
>> @@ -259,7 +259,7 @@
>>  #define RX_RING_SIZE    128  #define MEDIA_MASK     31
>>  
>> -#define PKT_BUF_SZ        1536    /* Size of each temporary Rx 
>> buffer. */
>> +#define PKT_BUF_SZ        1540    /* Size of each temporary Rx 
>> buffer. */
> 
> 
> 
> This is the reason why the tulip "vlan" patch is continually rejected. 
> You shouldn't need to increase this constant, but rather follow the 
> other "large MTU" driver conversions.

Has anyone tried just leaving this line as it was (but adding the rest
of the patch)?  I believe the 1536 already has plenty of space and
can hold the extra 4 bytes w/out problem.

Ben

-- 
Ben Greear <[email-masked]>
Candela Technologies Inc  http://www.candelatech.com