From: Pablo Neira <pablo@eurodev•net>
To: Pablo Neira <pablo@eurodev•net>
Cc: Chris Wright <chrisw@osdl•org>,
netdev@oss•sgi.com, davem@davemloft•net, jmorris@redhat•com,
sds@epoch•ncsc.mil, serue@us•ibm.com
Subject: Re: [RFC][PATCH 2/3] netlink check sender, audit
Date: Sat, 12 Feb 2005 22:41:14 +0100 [thread overview]
Message-ID: <420E77FA.6080007@eurodev.net> (raw)
In-Reply-To: <420E334B.8060805@eurodev.net>
Pablo Neira wrote:
> I also see another option which is passing as parameter such function
> which check for capabilities/audit stuff to my netlink_process_skb
> function, calling it before process_msg. But in that case, the packet
> sent by a sender that doesn't has the right to was already enqueued. I
> understand that this is exactly what you are trying to avoid.
With your patch, a message from user space process that doesn't have the
capabilites follows this path:
sys_sendmsg() -> netlink_sendmsg() -> netlink_unicast() ->
netlink_sendskb() = discarded here.
Currently, it continues, for example in case of rtnetlink:
... -> netlink_sendskb() -> sk_data_ready(sk, len) -> rtnetlink_rcv() ->
rtnetlink_rcv_skb() -> rtnetlink_rcv_msg() = discarded here.
Nowadays the message is enqueued but it's discarded later. So if I'm not
missing anything, I don't see the point of adding a new function to
check for capabilities/audit stuff just a bit before.
--
Pablo
next prev parent reply other threads:[~2005-02-12 21:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-12 9:01 [RFC][PATCH 0/3] netlink check sender Chris Wright
2005-02-12 9:02 ` [RFC][PATCH 1/3] " Chris Wright
2005-02-12 9:05 ` [RFC][PATCH 2/3] netlink check sender, audit Chris Wright
2005-02-12 9:06 ` [RFC][PATCH 3/3] netlink check sender, rtnetlink Chris Wright
2005-02-12 16:48 ` [RFC][PATCH 2/3] netlink check sender, audit Pablo Neira
2005-02-12 21:41 ` Pablo Neira [this message]
2005-02-14 13:08 ` Stephen Smalley
2005-02-15 0:13 ` Chris Wright
2005-02-15 2:29 ` Pablo Neira
2005-02-15 2:36 ` Pablo Neira
2005-02-15 3:47 ` Chris Wright
2005-02-15 22:19 ` Pablo Neira
2005-02-15 22:22 ` Chris Wright
2005-02-15 22:27 ` Pablo Neira
2005-02-16 0:11 ` Chris Wright
2005-02-16 3:42 ` James Morris
2005-02-15 0:11 ` Chris Wright
2005-02-14 12:59 ` [RFC][PATCH 1/3] netlink check sender Stephen Smalley
2005-02-14 13:05 ` Stephen Smalley
2005-02-15 0:22 ` Chris Wright
2005-02-15 0:17 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420E77FA.6080007@eurodev.net \
--to=pablo@eurodev$(echo .)net \
--cc=chrisw@osdl$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=jmorris@redhat$(echo .)com \
--cc=netdev@oss$(echo .)sgi.com \
--cc=sds@epoch$(echo .)ncsc.mil \
--cc=serue@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox